Skip to content

Bump Crass to 1.0.8 for GHSA-pq4g-8rxf-4g29 - #195

Open
jeremy wants to merge 1 commit into
mainfrom
scanner-crass-1-0-8
Open

jeremy wants to merge 1 commit into
mainfrom
scanner-crass-1-0-8

Conversation

@jeremy

@jeremy jeremy commented Oct 24, 2026

Copy link
Copy Markdown
Member

Crass 1.0.7 is affected by GHSA-pq4g-8rxf-4g29, a CSS sanitizer bypass fixed in 1.0.8. This updates only Crass and its lockfile checksum.

Crass is present transitively through Loofah and rails-html-sanitizer. I found no engine call to CSS sanitization and no engine configuration that permits style attributes. This lockfile governs the engine's development and dummy-app environment; applications that consume the gem resolve their own lockfiles.

Validation on this exact change:

  • current ruby-advisory-db: no vulnerabilities
  • RuboCop: 270 files, no offenses
  • Brakeman: no warnings
  • actionlint: clean
  • zizmor: no findings
  • 481 runs, 1,193 assertions, 0 failures, 0 errors across all test files that do not require privileged mtr sockets or an installed Playwright browser

The full 490-test run reached 5 environment-only failures/errors in the two excluded probe files: mtr could not open raw sockets and Playwright's browser executable is not installed. The remaining 481 tests passed when run separately.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 22:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T23:00:14.300860Z 6282c36 Manual request
🔒 Security Review ✅ Completed 2026-10-24T23:01:26.620351Z 6282c36 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremy

jeremy commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

@codex review

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 6282c36d94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6282c36d94

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants