Add deployment and promotion settings flags to model push by mingminglang-baseten · Pull Request #180 · basetenlabs/baseten-cli

mingminglang-baseten · 2026-10-22T05:12:36Z

🚀 What

baseten model push can set the new deployment's instance type (--instance-type), autoscaling (--min-replica, --max-replica, …) and request backpressure (--request-backpressure-policy). With --environment, the environment also keeps them once the promotion completes. --autoscaling-schedule-update-json and the --override-* promotion flags apply only to the promotion into --environment, so they require it; the server enforces which settings need it.

Existing pushes are unchanged: a push without the new flags sends the same requests as before, checked by diffing the request bodies of main and this branch for plain, --environment, --preserve-env-instance-type, --create-environment-if-missing, --deployment-name/--region/--labels, --dry-run, --develop and --deploy-timeout/--no-build-cache pushes. No existing flag is renamed or removed.

💻 How

Maps the flags onto the new PushModelOptions fields from Add deployment and promotion settings to PushModelOptions baseten-go#74, sending each group only when one of its flags is passed.
The --override-* flags move into a shared PromotionSettingsOverrideFlags used by both promote and push, which also share the schedule JSON parsing and backpressure mapping.
--instance-type with --preserve-env-instance-type is a usage error, as on promote.

Before merging: go.mod pins basetenlabs/baseten-go#74's branch commit; repin to its main commit once it merges.

🔬 Testing

New push tests for settings with and without --environment, --instance-type with --preserve-env-instance-type, and an empty schedule update; the default push test also checks that none of the new fields are sent. go mod tidy, go fmt, go vet and the model tests pass.

🤖 Generated with Claude Code

…listing The usage command listed your teams and your Code settings in each with GET /v1/routes/settings/users/me/teams, which is being removed. Use GET /v1/teams for your teams and GET /v1/routes/settings/teams/{team}/users/me for your settings in each, which say the same things. Org admins are members of every team, so they still see every team. Claude-Session: https://claude.ai/code/session_01UkWMh7GwDgbmR88spBWMEm

Pins baseten-go to the client regenerated for the renamed Grid API, so every call site moves to the GetGrid*/PostGrid*/PatchGrid*/DeleteGrid* methods. grid usage now reads your settings from GET /v1/grid/team_settings/users/me and passes --team straight through as team_id: the server uses your only team, or asks for --team when you belong to several. The client-side team listing and name matching are gone, along with the "No usage this month" branch they fed. Claude-Session: https://claude.ai/code/session_01UkWMh7GwDgbmR88spBWMEm

Preserve the source PR's all-team usage and team name/ID filtering while using the current Grid API and Grid-named files. Resolve the usage implementation and test conflicts without restoring legacy command files.

* adding functionality to cli * Update go.sum * adding functionality to cli

`grid usage` listed your teams and fetched your settings in each to draw your spend against your limit, the one place the CLI still stitched teams together client-side. Per the review on this PR, usage is one command: `grid route usage [--team] [--user-id]`, whose arguments behave as the API does. Without --team, usage spans the teams you can see; without --user-id, members see their own usage and admins see everyone's. Your spend against your limit in a team is `grid user-settings describe`. Claude-Session: https://claude.ai/code/session_01UkWMh7GwDgbmR88spBWMEm

The list spans every team you can see unless --team narrows it, so two rows can share a name. A TEAM column, as the connection list already has, tells them apart. Claude-Session: https://claude.ai/code/session_01UkWMh7GwDgbmR88spBWMEm

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…nges in the prompt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cretz

Nothing blocking (I assume there are 0 changes/incompatibilities with people using push today)

cretz · 2026-10-22T16:20:46Z

-func promotionSettingsGroupOrNil[T comparable](group T) *T {
+// settingsGroupOrNil returns nil for a settings group with no fields set, so an
+// untouched group is omitted from the promote or push request.
+func settingsGroupOrNil[T comparable](group T) *T {


Pedantic, but maybe deploymentSettingsGroupOrNil?

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

linear · 2026-10-23T15:17:55Z

DI-2912

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

Upstream SDK PR #74 remains unmerged, so its merge and the documented dependency repin require final verification.

No open issues 🎉

What changed in this PR

Extends baseten model push with deployment configuration and promotion settings, reusing the existing promotion flag handling.

Changes:

Adds instance type, autoscaling, backpressure, schedule-update, and promotion-override flags.
Shares settings mapping between push and promote, omitting settings groups when unused.
Updates the SDK dependency and adds tests for settings payloads, default omission, and validation.

File	Description
`internal/cmd/command.model_push.go`	Maps new settings into push options and rejects conflicting instance-type flags.
`internal/cmd/command.model_push_test.go`	Tests settings payloads, omitted defaults, and invalid inputs.
`internal/cmd/command.model_deployment.go`	Reuses settings helpers across promote and push.
`go.sum`	Updates SDK dependency checksums.
`go.mod`	Pins the SDK commit providing the new push options.
`cmd/command.model.go`	Defines shared override flags and documents new push options.
`cmd/command.model_deployment.go`	Embeds the shared promotion override flags.

_{Review effort: Balanced}

youngzheng-oss and others added 28 commits October 15, 2026 09:42

grid rename

11378b5

Update command.harness_usage_test.go

2f35d1b

Merge branch 'main' into shivain/grid-rename

12e56e3

refactor(grid): align command files and symbols with Grid hierarchy

c518c93

Merge PR #165 usage team discovery into Grid commands

7397675

Preserve the source PR's all-team usage and team name/ID filtering while using the current Grid API and Grid-named files. Resolve the usage implementation and test conflicts without restoring legacy command files.

Update go.sum

0ee24ff

feat(grid): Add settings, connections, and classifier commands (#173)

83efd56

* adding functionality to cli * Update go.sum * adding functionality to cli

responding to comments (1)

9f45d0d

responding to comments (2)

208984d

renaming

a52e787

Update command.grid.go

d3f8bf5

Removing to match spec

1caded8

updating with new sdk

a827c61

grid settings flag rename to route id

19b14d8

updated create/update outputs to be concise confirmations

0125e94

Update command.grid_test.go

f26ba07

test renaming

bf1a1f2

matching create (use hasGridRouteClassifier)

a4802ba

Show the team in grid route list

0de0e7f

The list spans every team you can see unless --team narrows it, so two rows can share a name. A TEAM column, as the connection list already has, tells them apart. Claude-Session: https://claude.ai/code/session_01UkWMh7GwDgbmR88spBWMEm

Add promotion-time settings flags to model deployment promote

ed5413a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Reject conflicting promote flags, tighten schedule JSON, and name cha…

81572b8

…nges in the prompt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Reject an empty schedule update and misspelled keys inside schedules

76757d4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into mingming/promotion-time-settings

be28ce8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Inline promote flags and leave schedule validation to the server

8727802

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Add deployment and promotion settings flags to model push

ef9bdc8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mingminglang-baseten marked this pull request as ready for review October 22, 2026 05:15

mingminglang-baseten requested a review from cretz October 22, 2026 05:59

cretz mentioned this pull request Oct 22, 2026

Add promotion-time settings flags to model deployment promote #176

Merged

cretz approved these changes Oct 22, 2026

View reviewed changes

Rename promote flags to --instance-type and unprefixed autoscaling flags

d6d5138

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mingminglang-baseten mentioned this pull request Oct 22, 2026

Add deployment and promotion settings to PushModelOptions basetenlabs/baseten-go#71

Closed

Merge mingming/promotion-time-settings into mingming/push-time-settings

27e63d2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Base automatically changed from mingming/promotion-time-settings to main October 23, 2026 19:06

mingminglang-baseten and others added 2 commits October 23, 2026 19:27

Merge origin/main into mingming/push-time-settings

ba332df

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Add --instance-type to model push and rename the settings helper

d945bab

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI balanced review requested due to automatic review settings October 23, 2026 23:28

Copilot started reviewing on behalf of mingminglang-baseten October 23, 2026 23:29

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

Navigation Menu

Repository navigation

Add deployment and promotion settings flags to model push - #180

Add deployment and promotion settings flags to model push#180
mingminglang-baseten wants to merge 32 commits into
mainfrom
mingming/push-time-settings

mingminglang-baseten commented Oct 22, 2026 •

edited

Loading

Uh oh!

cretz left a comment

Uh oh!

cretz Oct 22, 2026

Uh oh!

linear Bot commented Oct 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mingminglang-baseten commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 What

💻 How

🔬 Testing

Uh oh!

cretz left a comment

Choose a reason for hiding this comment

Uh oh!

cretz Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

linear Bot commented Oct 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mingminglang-baseten commented Oct 22, 2026 •

edited

Loading