fix: raise clear errors for missing values in panel index - #716
Open
shuxue6662-a11y wants to merge 1 commit into
Open
fix: raise clear errors for missing values in panel index#716shuxue6662-a11y wants to merge 1 commit into
shuxue6662-a11y wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 101 101
Lines 17426 17448 +22
Branches 1430 1433 +3
=======================================
+ Hits 17347 17369 +22
Misses 29 29
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PanelData.entity_ids/PanelData.time_idsreturn the raw pandas MultiIndex codes. When the panel index contains missing values (NaN), pandas encodes them as-1, so the ids silently contain negative values andpanel_structure_stats()fails later with a genericnumpyerror:This PR makes the failure mode explicit:
entity_idsandtime_idsnow raise aValueErrorexplaining that the panel index contains missing values (NaN), which are not supported.panel_structure_stats()now validates that ids are non-negative and raises a clearValueErrornaming the statistic and the cause, protecting every call site.Motivation and Context
Fixes #614.
How Has This Been Tested?
panel_structure_stats.pytest linearmodels/tests/panel/test_data.py-> 185 passed.black --check,isort --check-only,flake8, andruff checkare clean on the changed files.