Repository navigation
Clamp wait delays before integer conversion - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delay configured as a large float (for example
1e20inenv.php) triggers a PHP 8.5 warning during the integer cast. Magento converts that warning into an exception, preventing runtime configuration from being generated even when Wait After Onload is disabled.Clamp numeric values to 0–30000 before converting to an integer, and normalize
INF,-INF, andNANto zero. Add regression coverage for numeric extremes, overflowing numeric strings, fractions, and invalid inputs through the normalizer, save backend, and disabled-delay runtime path. The tests promote PHP warnings into exceptions.This fix should merge before #19 enables PHP 8.5 installation.
Validation:
git diff --checkpasses.CI prerequisite: #21 repairs the native Magento baseline after an unrelated Flysystem security advisory blocked fresh 2.4.7 installs. That branch is included here for combined validation and will merge first, leaving this PR with the delay fix and its regression tests.