Repository navigation
Add credential test for n8n review (0.2.3) - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The n8n Creator Portal review of 0.2.2 came back "Changes Required": missing credential test. The BatchData API credential class had no
test; the check lived on the nodes as atestedBymethod.Changes
BatchDataApicredential now hastest: ICredentialTestRequest:GET https://api.batchdata.com/api/v2/property/search-sessions?take=1. TheauthenticateBearer header is applied. A valid token returns 200 and a bad token returns 401. The call is read-only and does not bill property records (the same endpoint the New Search Session trigger polls).responseCoderules give clear messages for 401, 403 and 429.testedBy: 'batchDataApiTest'methods (credentialMethods.ts,credentialTest.ts) from all three nodes, so the credential test is the single check.testedBy.Verification
n8n-node lintpasses, and so do the build and 40/40 tests.analyzePackage(@n8n/scan-community-package 0.43.0, with inline config disabled) passes on both the source and the packed 0.2.3 tarball.After merge, tag
0.2.3to publish with provenance.