fix(toolchain): exclude libpython from runtime in recent releases - #4091
fix(toolchain): exclude libpython from runtime in recent releases#4091aignas wants to merge 5 commits into
Conversation
Use the already existing auto-detection and exclude libpython and friends as suggested in the upstream ticket. Fixes bazel-contrib#3534
|
Re-read the comment and realized that this should be config flag gated, will PoC the interface |
|
Re: interface: I had three thoughts One: a coarse/vague string flag like minimal/full/some-use-case-name Two: a string flag of pieces to include/exclude, similar to how output group flag works. -libs,+pip,-headers,-tcl,etc Three: a flag to pick the runtime flavor, ie install_only (which is a 26M install compared to the other tars) (this flag will be added regardless, eventually) |
|
I am done for the day so I'll quickly respond:
I chose to be very specific here with respect to what we are including. I chose to have a runtime inclusion behaviour because we already have the thing extracted, so we can support various configurations given the extracted contents and what is present.
This is a nice idea, but could feel clunky? Maybe not... The nice thing here is that we could trampoline off of what user supplies and use FeatureFlagInfo to get derived flags for what we need. I like this because it keeps the API surface small and extendible.
This can be already achieved via what is provided to the machinery as the URLs. I thought the Feel free to hack on this and mold it to your liking. |
Use the already existing auto-detection and exclude libpython and
friends as suggested in the upstream ticket.
Fixes #3534