refactor(pypi): split whl_library_targets - #4101
Merged
rickeylev merged 4 commits intoAug 23, 2026
Merged
Conversation
Summary: - Split the macros into 2 separate files for easier management. - Split the tests for each macro as well. Work towards bazel-contrib#2948
…headers Copyright headers were incorrectly added to new files, and the bzl_library dependencies for whl_library_targets became obsolete after splitting the macro implementation. Remove copyright boilerplate from newly created files and update whl_library_targets in BUILD.bazel to depend on whl_library_deps_targets and whl_library_srcs.
rickeylev
approved these changes
Aug 23, 2026
rickeylev
enabled auto-merge
August 23, 2026 06:17
…export symbols When whl_library_targets was split, generate_whl_library_build_bazel still generated load statements referencing whl_library_targets.bzl for whl_library_deps_targets, causing symbol lookup failures in repos. Update generate_whl_library_build_bazel to load from the specific split .bzl module matching the function name, and explicitly re-export the split macro symbols from whl_library_targets.bzl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Work towards #2948