Repository navigation
fix(elixir_app): pass deps to app_file - #2
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
elixir_app accepts deps and compiles against them, but did not pass them to app_file. The generated .app file therefore listed only kernel, stdlib, elixir and extra_apps in applications, so OTP did not start the dependency applications first. Pass deps to app_file. The .app file now lists the dependency apps. Test: test/app_deps builds an app that depends on a second app and checks that the applications list of its .app file contains it. The test fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
elixir_appacceptsdepsand compiles against them, but does not pass them toapp_file. The generated.appfile lists onlykernel,stdlib,elixirandextra_appsinapplications, so OTP does not start the dependency applications first.Change
Pass
depstoapp_file. One line. The.appfile now lists the dependency apps inapplications, so OTP starts them before the app.Test
test/app_deps: an app that depends on a second app, and ash_testthat checks theapplicationslist of its.appfile. Onmainit fails with{applications,[kernel,stdlib,elixir]}; with the fix it is{applications,[kernel,stdlib,elixir,dep_app]}.Test output (OTP 29.0, Elixir 1.20.3, Bazel 9.2.0,
--nohome_rc)bazel test //...intest/: Executed 5 out of 5 tests: 5 tests pass. The CI negative checks (failing_test,broken_test,empty_test) fail as expected. The OTP 28.5 / Elixir 1.19.5 pair was not run as a whole.Assisted by Claude.