Repository navigation
Retire the albersdown 1.x theme copy from the pkgdown site - #8
Open
bbuchsbaum wants to merge 1 commit into
Open
bbuchsbaum wants to merge 1 commit into
bbuchsbaum wants to merge 1 commit into
Conversation
pkgdown/extra.css and pkgdown/extra.js held a copy of the albersdown 1.x stylesheet and class-setting script. pkgdown loads extra.css after the template's albers.css, so the stale copy overrode the current theme (uppercase headings, section numbers run into heading text). Ran albersdown::use_albersdown(apply_to = "new"): extra.css removed, extra.js reduced to a window.albersdownDefaults line (teal / homage, taken from the vignette's params), Config/Needs/website pointed at bbuchsbaum/albersdown, and the local .albersdown.bak/ backup ignored. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 12 12
Lines 1090 1090
=======================================
Hits 1015 1015
Misses 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What was wrong
pkgdown/extra.css(1,190 lines, header/* ---------- Albersdown: Bauhaus geometric system ---------- */) andpkgdown/extra.js(308 lines) were copies of the albersdown 1.x stylesheet and class-setting script. pkgdown loadsextra.cssafter the template'salbers.css, so the stale copy overrides the current albersdown theme: uppercase headings, section numbers jammed into heading text. The live site currently serves only this 1.x copy (its pages linkextra.css/extra.jsand noalbers.css;<body>has no palette class, so the 1.x:rootred accent applies).What changed
Generated by
albersdown::use_albersdown(".", apply_to = "new")(albersdown dev, commit 61688b2):pkgdown/extra.css: removed.pkgdown/extra.js: replaced bywindow.albersdownDefaults = { family: "teal", preset: "homage", style: "minimal" };DESCRIPTION:Config/Needs/website: albersdown->bbuchsbaum/albersdown(the pkgdown workflow installs it vianeeds: website)..gitignore: appended.albersdown.bak/(local backup of the removed files;.Rbuildignorealready had it).Visible change: teal / homage was taken from the vignette's
params(family: teal,preset: homage). The live site renders with the 1.x red accent and no preset, so the site's accent colour moves from red to teal. Passfamily/presettouse_albersdown()if red is preferred.Verification
Partial build (
init_site,build_home,build_reference_index,build_article("templateflow")) into a scratch directory with dev albersdown:albers.cssis byte-identical to albersdown 61688b2inst/pkgdown/assets/albers.css.extra.css.bodyclassespalette-teal preset-homage style-minimal,--accent#2E918C, firsth2text-transform: none, no page errors. Screenshot checked: sentence-case headings, section numbers set apart from heading text.Not changed here, for follow-up:
vignettes/albers.cssandvignettes/albers.jsare 1.x leftovers (the vignette'scss:/includes:keys sit at top level, not underoutput:, so they are inert); pkgdown copiesvignettes/albers.csstoarticles/albers.cssbut no page links it.AGENTS.mdis published asAGENTS.htmlon the site.🤖 Generated with Claude Code