Skip to content

Retire the albersdown 1.x theme copy from the pkgdown site - #8

Open
bbuchsbaum wants to merge 1 commit into
mainfrom
site/albersdown-retire-1x
Open

bbuchsbaum wants to merge 1 commit into
mainfrom
site/albersdown-retire-1x

Conversation

@bbuchsbaum

Copy link
Copy Markdown
Owner

What was wrong

pkgdown/extra.css (1,190 lines, header /* ---------- Albersdown: Bauhaus geometric system ---------- */) and pkgdown/extra.js (308 lines) were copies of the albersdown 1.x stylesheet and class-setting script. pkgdown loads extra.css after the template's albers.css, so the stale copy overrides the current albersdown theme: uppercase headings, section numbers jammed into heading text. The live site currently serves only this 1.x copy (its pages link extra.css/extra.js and no albers.css; <body> has no palette class, so the 1.x :root red accent applies).

What changed

Generated by albersdown::use_albersdown(".", apply_to = "new") (albersdown dev, commit 61688b2):

  • pkgdown/extra.css: removed.
  • pkgdown/extra.js: replaced by window.albersdownDefaults = { family: "teal", preset: "homage", style: "minimal" };
  • DESCRIPTION: Config/Needs/website: albersdown -> bbuchsbaum/albersdown (the pkgdown workflow installs it via needs: website).
  • .gitignore: appended .albersdown.bak/ (local backup of the removed files; .Rbuildignore already had it).

Visible change: teal / homage was taken from the vignette's params (family: teal, preset: homage). The live site renders with the 1.x red accent and no preset, so the site's accent colour moves from red to teal. Pass family/preset to use_albersdown() if red is preferred.

Verification

Partial build (init_site, build_home, build_reference_index, build_article("templateflow")) into a scratch directory with dev albersdown:

  • Built albers.css is byte-identical to albersdown 61688b2 inst/pkgdown/assets/albers.css.
  • No built page links extra.css.
  • Headless Chromium on home, reference index and the article: body classes palette-teal preset-homage style-minimal, --accent #2E918C, first h2 text-transform: none, no page errors. Screenshot checked: sentence-case headings, section numbers set apart from heading text.

Not changed here, for follow-up: vignettes/albers.css and vignettes/albers.js are 1.x leftovers (the vignette's css:/includes: keys sit at top level, not under output:, so they are inert); pkgdown copies vignettes/albers.css to articles/albers.css but no page links it. AGENTS.md is published as AGENTS.html on the site.

🤖 Generated with Claude Code

pkgdown/extra.css and pkgdown/extra.js held a copy of the albersdown 1.x
stylesheet and class-setting script. pkgdown loads extra.css after the
template's albers.css, so the stale copy overrode the current theme
(uppercase headings, section numbers run into heading text).

Ran albersdown::use_albersdown(apply_to = "new"): extra.css removed,
extra.js reduced to a window.albersdownDefaults line (teal / homage,
taken from the vignette's params), Config/Needs/website pointed at
bbuchsbaum/albersdown, and the local .albersdown.bak/ backup ignored.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Security Agent completed successfully with no findings requiring human review, and Cursor Bugbot was not running on this PR. No prior approval from this automation needed to be dismissed.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.11%. Comparing base (10c7eac) to head (262401d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          12       12           
  Lines        1090     1090           
=======================================
  Hits         1015     1015           
  Misses         75       75           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant