check signed-message length in AIMerSigner.verifySignature - #2401
Closed
rootvector2 wants to merge 1 commit into
Closed
check signed-message length in AIMerSigner.verifySignature#2401rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the patch, now merged and up on https://downloads.bouncycastle.org/betas - one minor change, we optimised the test. Things are starting to take a while... |
hubot
pushed a commit
that referenced
this pull request
Aug 22, 2026
…ture to be exactly the message plus the parameter set's signature size, so that a short signature is reported as a failed verification rather than indexed past its end, and a valid one with data appended to it no longer verifies, relates to github #2401.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIMerSigner.verifySignatureslices the signature out of themessage || signatureenvelope at offsetmessage.lengthwithout checking the buffer is that long, so a truncated signature throwsArrayIndexOutOfBoundsExceptionout ofSignature.verify()and a valid one with bytes appended still verifies (found by feeding wrong-length signatures to every BCPQCSignatureservice); it now requires exactlymessage.length + getSignatureBytes()and returns false otherwise, the guard the Falcon, Faest, Mayo, Snova and QRUOV signers already carry.