use constant-time comparison for srp-6a evidence messages - #2406
Open
rootvector2 wants to merge 1 commit into
Open
use constant-time comparison for srp-6a evidence messages#2406rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRP6Server.verifyClientEvidenceMessageandSRP6Client.verifyServerEvidenceMessagecheck the peer's evidence message (M1/M2, a keyed authenticator derived from the shared secretS) withBigInteger.equals, which walks the magnitude words and returns at the first difference, so the compare time depends on how many leading bytes match a value the unauthenticated peer is trying to guess. Switched both toArrays.constantTimeAreEqualover the fixed encodings, matching the siblingJPAKEUtilMacTag check, in the lightweightcrypto.agreement.srppackage and the BCTLStls.crypto.impl.jcajce.srpcopies. Found while auditing the SRP path after the recentcreateBlindedExponentmodPow hardening in these same classes; the accept/reject result is unchanged andSRP6Testnow covers the evidence-verification path.