Repository navigation
Conversation
Previously gtest was an unconditional depdency of exemplar even though it's only used for tests. This means gtest is pulled-in even when `BEMAN_EXEMPLAR_BUILD_TESTS` is not set. This change makes it a test dependency that is not pulled when test building flag is set to off.
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
ednolan and
steve-downey
as code owners
October 10, 2026 23:21
|
coverage: 100.0%. remained the same — river/test-dep into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously gtest was an unconditional depdency of exemplar even though it's only used for tests.
This means gtest is pulled-in even when
BEMAN_EXEMPLAR_BUILD_TESTSis not set.This change makes it a test dependency that is not pulled when test building flag is set to off.