Skip to content

Implement it.base_code_units() for forward ranges per SG9 feedback #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Sep 14, 2026
Merged

Implement it.base_code_units() for forward ranges per SG9 feedback #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions include/beman/utf_view/to_utf_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,15 @@ struct to_utf_view<V, E, ToType>::exposition_only_iterator : detail::iter_catego
return std::move(exposition_only_current_);
}

/* PAPER: constexpr value_type operator*() const; */
constexpr auto base_code_units() const
requires std::ranges::forward_range<exposition_only_Base>
{
return std::ranges::subrange(
exposition_only_current_,
std::ranges::next(exposition_only_current_, exposition_only_to_increment_));
}

/* PAPER: constexpr value_type operator*() const; */
/* !PAPER */
constexpr value_type operator*() const {
if constexpr (E == to_utf_view_kind::expected) {
Expand Down Expand Up @@ -490,8 +498,11 @@ struct to_utf_view<V, E, ToType>::exposition_only_iterator : detail::iter_catego
}
if (exposition_only_current_ != exposition_only_end()) {
exposition_only_read();
} else if constexpr (!std::ranges::forward_range<exposition_only_Base>) {
exposition_only_buf_index_ = -1;
} else {
exposition_only_to_increment_ = 0;
if constexpr (!std::ranges::forward_range<exposition_only_Base>) {
exposition_only_buf_index_ = -1;
}
}
}
}
Expand Down
Loading
Loading