Skip to content

Set difference_type to range_difference_t<Base>, not ptrdiff_t #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Sep 22, 2026
Merged

Set difference_type to range_difference_t<Base>, not ptrdiff_t #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/beman/utf_view/to_utf_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ struct to_utf_view<V, E, ToType>::exposition_only_iterator : detail::iter_catego
using value_type =
std::conditional_t<E == to_utf_view_kind::expected, std::expected<ToType, utf_transcoding_error>, ToType>;
using reference_type = value_type;
using difference_type = std::ptrdiff_t;
using difference_type = std::ranges::range_difference_t<exposition_only_Base>;

private:
/* !PAPER */
Expand Down
2 changes: 1 addition & 1 deletion papers/P2728.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ public:
using iterator_category = @*see below*@; // @*not always present*@
using value_type = conditional_t<E == to_utf_view_kind::expected, expected<ToType, utf_transcoding_error>, ToType>;
using reference_type = value_type;
using difference_type = ptrdiff_t;
using difference_type = range_difference_t<@*Base*@>;

private:
iterator_t<@*Base*@> @*begin_*@{}; // @*exposition only*@, present only if
Expand Down
Loading