Repository navigation
Constrain code unit adaptors to same-width integral and byte sources - #262
Merged
Merged
Conversation
Per SG16 feedback, replace the convertible_to constraint on as_charT with a rule that accepts a source type U if it is Char itself, or if it is std::byte or a non-bool integral type with sizeof(U) == sizeof(Char). The exposition-only functor now performs the cast with static_cast. This rejects narrowing and widening conversions, conversions between distinct charN_t types, floating-point and bool sources, enumerations other than std::byte, and class types, while accepting std::byte and same-width integer buffers. Add a design discussion section with rationale, alternatives, and a conversion table, and add unit tests covering the accept/reject matrix and the static_cast semantics for byte and signed sources. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
coverage: 99.762%. remained the same — enolan_castconversion2 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per SG16 feedback, replace the convertible_to constraint on as_charT with a rule that accepts a source type U if it is Char itself, or if it is std::byte or a non-bool integral type with sizeof(U) == sizeof(Char). The exposition-only functor now performs the cast with static_cast.
This rejects narrowing and widening conversions, conversions between distinct charN_t types, floating-point and bool sources, enumerations other than std::byte, and class types, while accepting std::byte and same-width integer buffers.
Add a design discussion section with rationale, alternatives, and a conversion table, and add unit tests covering the accept/reject matrix and the static_cast semantics for byte and signed sources.