Skip to content

Pyvista Plotting Support - #237

Closed
lz069 wants to merge 16 commits into
bempp:mainfrom
lz069:main
Closed

lz069 wants to merge 16 commits into
bempp:mainfrom
lz069:main

Conversation

@lz069

@lz069 lz069 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Pyvista Plotting of 3d model is supported. The argument "notebook_toggle" is for control of viewing within jupyter window or pyvista gui window. Qt (Pyqt or Pyside) bindings should be installed.

@lz069
lz069 marked this pull request as draft September 15, 2026 09:30
@lz069
lz069 marked this pull request as ready for review September 15, 2026 09:30
@lz069
lz069 marked this pull request as draft September 15, 2026 09:31
@lz069
lz069 marked this pull request as ready for review September 15, 2026 09:31
Handle unsupported types and exceptions in viewer logic.
Replaced Exception with print statement for better error handling.
Replaced print statements with ValueError raises for better error handling.
@lz069

lz069 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@mscroggs How can I pass the check

@mscroggs

Copy link
Copy Markdown
Member

@mscroggs How can I pass the check

Looks like there's been a new ruff version since anyone last made an edit to Bempp-cl, which is picking up a lot of code style issues unrelated to your changes. I'll try to fix these in a separate PR

@lz069

lz069 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@mscroggs How can I pass the check

Looks like there's been a new ruff version since anyone last made an edit to Bempp-cl, which is picking up a lot of code style issues unrelated to your changes. I'll try to fix these in a separate PR

I got it. Thank you very much. Hope this merge could work.

@lz069 lz069 closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants