Repository navigation
Conversation
Added notebook_toggle parameter to plot method.
Remove docstring for visualize_with_pyvista function.
lz069
marked this pull request as draft
September 15, 2026 09:30
lz069
marked this pull request as ready for review
September 15, 2026 09:30
lz069
marked this pull request as draft
September 15, 2026 09:31
lz069
marked this pull request as ready for review
September 15, 2026 09:31
Handle unsupported types and exceptions in viewer logic.
Replaced Exception with print statement for better error handling.
Replaced print statements with ValueError raises for better error handling.
Contributor
Author
|
@mscroggs How can I pass the check |
Member
Looks like there's been a new ruff version since anyone last made an edit to Bempp-cl, which is picking up a lot of code style issues unrelated to your changes. I'll try to fix these in a separate PR |
Contributor
Author
I got it. Thank you very much. Hope this merge could work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyvista Plotting of 3d model is supported. The argument "notebook_toggle" is for control of viewing within jupyter window or pyvista gui window. Qt (Pyqt or Pyside) bindings should be installed.