Repository navigation
Repin dtolnay/rust-toolchain to the current v1 - #1253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lint / Zizmor Onlinefailed on #1251 (run https://github.com/bencherdev/bencher/actions/runs/38846843953, job https://github.com/bencherdev/bencher/actions/runs/38846843953/job/116799199507) with one medium finding, exit 13:Line 18 is
dtolnay/rust-toolchain@e2a55d2ffb04f378e9626c28d38b36d230d1e12f # v1, pinned by #1199. The upstreamv1tag moved to683b588c487a69d01f6c6ddf40f036ff682cc2c8on 2026-10-16.develcarries the same pin, so the job is red on every run since. The job iscontinue-on-error: true, so it does not block a merge.Change
Repin
update_sandbox.ymlto the commitv1points at today and keep the# v1comment, as #1199 did. The hash was resolved from the GitHub refs API (v1is a lightweight tag on that commit). No other workflow or composite action uses this action.Upstream range
e2a55d2f...683b588cis one commit, "Add 1.99.1 patch release", which adds1.99.1to the patch release list inscripts/update-revs.sh.action.ymlis unchanged, so this call site (toolchain: stable) runs exactly the same steps.Other moving refs
Every other pin whose comment names a moving ref still matches it today:
rui314/setup-mold@339e96b4 # v1(14 sites),dawidd6/action-download-artifact@b6e2e706 # v21(2 sites), andsuperfly/flyctl-actions/setup-flyctl@ed8efb33 # master(3 sites, the currentmasterhead). The online pass below proves it.Verification
zizmor 1.25.2, the version CI pins, from the same digest-pinned image
zizmor-actionruns (ghcr.io/zizmorcore/zizmor:1.25.2@sha256:14ea7f5c...), with the action's arguments (--persona=regular --format=github, plus--no-online-auditsfor the offline job):develref-version-mismatchfinding aboveCI on this pull request is the final check.