Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1640.
Once a prefix has been consumed,
String.starts_withshould not need to inspect the remaining haystack just to return True. The old haystack-first recursion left generic empty-prefix and known-prefix laws stuck.This puts the internal recursion in pattern-first order while keeping the public
(s, p)argument order. A separate internalgois needed because Bend does not allow matching an earlier binder after a later one. The old internal helper is removed, not aliased.The new test checks empty prefixes, one- and two-character prefixes over arbitrary tails, and an early mismatch over arbitrary tails. The same empty-prefix program fails
--check-onlyon e5527d5 and passes after this change. This is a normalization improvement, not a soundness fix. AI-assisted.Checked with the independent Lean 4.34 kernel: both the new generic prefix laws and the existing
string_containslaws report ALL PROOFS CHECK. The new program also runs on C and JS; the existing string-kit program keeps all 36 expected outputs on both targets.