Repository navigation
Conversation
f32_bits and f32_from_bits each allocated a Float32Array/Uint32Array pair per call. Reuse one private 4-byte DataView for both, removing the per-call allocation on numeric code paths. Behavior is unchanged (little-endian, matching the previous typed-array view). Resolves bendlang#1638.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1638.
f32_bitsandf32_from_bitsin the emitted JS runtime each allocated a freshFloat32Array/Uint32Arraypair per call. Reuse one private 4-byteDataViewfor both, removing the per-call allocation on numeric code paths.Behavior is unchanged: little-endian (matching the previous typed-array view), so signed zero, subnormals, the largest finite F32, and Infinity round-trip identically. NaN-payload guarantees are unchanged (the JS lane does not preserve them, per WONTFIX).
I verified equivalence against the previous implementation for a range of values (signed zero, subnormals, 3.4e38, Infinity, NaN, and arbitrary u32 bit patterns) with a standalone script.