Skip to content

Update lockfiles and use strict PHPUnit assertions #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromegamez merged 2 commits into from
Oct 9, 2026
Merged

Update lockfiles and use strict PHPUnit assertions #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d90b204
Lock file maintenance
renovate[bot] Oct 9, 2026
7993066
Use strict assertions instead of empty checks
jeromegamez Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
662 changes: 356 additions & 306 deletions docs/uv.lock
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/Integration/AuthTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ public function testBatchForceDeleteUsers(): void

$this->assertSame(3, $result->successCount());
$this->assertSame(0, $result->failureCount());
$this->assertEmpty($result->rawErrors());
$this->assertSame([], $result->rawErrors());
}

public function testSetCustomUserClaims(): void
Expand Down Expand Up @@ -791,7 +791,7 @@ public function testSignInAnonymously(): void
$uid = $token->claims()->get('sub');

$this->assertIsString($uid);
$this->assertNotEmpty($uid);
$this->assertNotSame('', $uid);

// This should not throw an exception because the user exists
$this->auth->getUser($uid);
Expand Down
6 changes: 3 additions & 3 deletions tests/Integration/MessagingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public function testSendMulticastMessageToTwoInvalidRecipients(): void

$this->assertTrue($report->hasFailures());
$this->assertCount(2, $report->failures());
$this->assertEmpty($report->successes());
$this->assertCount(0, $report->successes());

$items = $report->failures()->getItems();

Expand Down Expand Up @@ -378,7 +378,7 @@ public function testSendMessageToUnknownToken(): void
try {
$this->messaging->send(['token' => self::$unknownToken]);
} catch (NotFound $e) {
$this->assertNotEmpty($e->errors());
$this->assertNotSame([], $e->errors());

throw $e;
}
Expand All @@ -391,7 +391,7 @@ public function testGetAppInstanceForUnknownToken(): void
try {
$this->messaging->getAppInstance(self::$unknownToken);
} catch (NotFound $e) {
$this->assertNotEmpty($e->errors());
$this->assertNotSame([], $e->errors());

throw $e;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Auth/ActionCodeSettings/ValidatedActionSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function testItRejectsInvalidSettings(): void

public function testItCanBeEmpty(): void
{
$this->assertEmpty(ValidatedActionCodeSettings::empty()->toArray());
$this->assertSame([], ValidatedActionCodeSettings::empty()->toArray());
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Exception/MessagingApiExceptionConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public function testItConvertsASenderIdMismatchResponseIdentifiedByItsErrorCode(
$converted = $this->converter->convertResponse($response);

$this->assertInstanceOf(SenderIdMismatch::class, $converted);
$this->assertNotEmpty($converted->errors());
$this->assertNotSame([], $converted->errors());
}

public function testItConvertsASenderIdMismatchResponseIdentifiedByItsMessage(): void
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/RemoteConfig/TemplateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function testParametersCanBeRemoved(): void
->withRemovedParameter('foo')
;

$this->assertEmpty($template->parameters());
$this->assertSame([], $template->parameters());
}

public function testParameterGroupsCanBeRemoved(): void
Expand All @@ -123,7 +123,7 @@ public function testParameterGroupsCanBeRemoved(): void
->withRemovedParameterGroup('group')
;

$this->assertEmpty($template->parameterGroups());
$this->assertSame([], $template->parameterGroups());
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Request/CreateUserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class CreateUserTest extends TestCase
public function testCreateNew(): void
{
$request = CreateUser::new();
$this->assertEmpty($request->jsonSerialize());
$this->assertSame([], $request->jsonSerialize());
}

/**
Expand Down
90 changes: 45 additions & 45 deletions tools/.firebase/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading