Repository navigation
Pin ruff lint rules to the current rule set - #15
Merged
Merged
Conversation
The project had no ruff config, so it linted with ruff's default rules. Ruff 0.16 widened those defaults from E4/E7/E9/F to roughly two dozen rule families, which is why Dependabot's upgrade (#13) fails CI with 313 findings in unchanged code. Select the ruff 0.15 defaults explicitly so the lint result no longer depends on the installed ruff version. Adopting more rules can happen separately, together with the fixes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks #13 (Dependabot Python updates), which fails the Lint step.
The project had no
[tool.ruff]config, so it relied on ruff's default rules. #13 bumps ruff from 0.15.15 to 0.16.8, and 0.16 widened those defaults fromE4, E7, E9, Fto roughly two dozen rule families (BLE,I,UP,S,RUF,SIM, …). That produced 313 findings in code the PR doesn't touch. The biggest groups areBLE001(115, broadexcept Exception),I001(68, import order), andUP017(35).This PR selects the ruff 0.15 defaults explicitly, so lint results no longer change when ruff is upgraded. Same approach as the SwiftFormat pin in #11. Adopting stricter rules can be its own PR together with the fixes. Many of the
BLE001catches look intentional, since the agent shouldn't crash, so each one needs a judgment call.Testing
ruff check src testspasses with ruff 0.15.15 (current lock) and 0.16.8 (Dependabot's version).pytest -q: 278 passed.uv lock --checkis clean, and the lockfile is unchanged.openai2.x to 3.16.2.After merging
Comment
@dependabot rebaseon #13 so it rebuilds on top of this, and CI should pass.🤖 Generated with Claude Code