Repository navigation
Fix/medium bugs - #106
Merged
Merged
Fix/medium bugs#106
Conversation
Before every job the window checked the RAR password by testing the whole archive, so a multi-gigabyte encrypted RAR was decoded in full before anything was extracted, and again for the next job. The check now decodes up to the first encrypted file and stops there; volume sets still test in full, since they cannot stop early. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Files came out of a RAR on Linux and macOS readable by their owner alone, because each is written through a temporary file, which is created 0600, and renamed into place. The temporary is now created 0666 so the umask decides, as for any new file, and the execute bits a member recorded on Unix are added, as the other formats do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7z and the disk list name a folder by its bare name, where ZIP adds a trailing slash. A folder row is matched against the entries starting with its path and a slash, so an empty 7z folder matched nothing and could not be ticked, and a 7z folder's own entry was left out when the folder was picked. Folder entries are now compared with the slash on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reading a large archive showed the opening screen with no way out until it finished. It now has a Cancel button, and Escape does the same: the reading thread is told to stop, nothing it still sends is applied, and the window goes back to the folder it came from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
File managers put copied files on the clipboard as a text/uri-list, whose lines end in CRLF as its RFC says. arboard splits the list at the line feed alone and leaves the carriage return on every path, so each named a file that did not exist and the paste did nothing. The return is now taken off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task asking whether to replace a file waits for the answer and does not look at its stop flag meanwhile, so pressing stop on it did nothing until somebody answered a question that was no longer on screen. Stopping it now answers Cancel and takes the question away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Windows and macOS the disk ignores case, so renaming note.txt to Note.txt found the new name already taken, by the file itself, and refused. A name that differs only in case from the old one is now renamed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The band was cleared only by the drag-stopped event of the blank space that started it. When rows filled that space mid-drag the space was no longer there to report the release, and the band stayed alive, forcing the selection on every later frame. It now ends on any frame where the primary button is up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The member permissions recorded for extraction are only read by the reader behind the rar feature, so a build without it failed on a field that was never read. The field is now behind the feature as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.