chore(cli): stop leaving e2e scratch as untracked "fixtures" - #662
Merged
Conversation
`src/sdk/cli/test/fixtures/` holds no authored fixture. Every directory in it — drift-repo, test-repo, empty-repo, arch-repo, sdlc-core, parity-test — is built by an `fs.ensureDir` in the e2e that uses it, and most are removed again in `afterAll`. Nothing under the path has ever been tracked. They survive only when a run is interrupted before its teardown, and then sit as untracked forever: today's tree carried drift-repo's generated evolith.yaml and a drift-history.json stamped 2026-08-21. That is the exact shape the root .gitignore already warns about two entries up — CLI artefacts that "se commitearon por accidente una vez y fosilizaron como si fueran taxonomia". The comment names the trap in the other direction too: a real committed fixture dropped in here would be ignored silently, so it belongs in test-project/ or needs a deliberate force-add. Verified by recreating the scratch tree: `git status` reports only this file, `git check-ignore -v` names the rule, and the tracked specs under `test/` are untouched by the pattern. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/sdk/cli/test/fixtures/holds no authored fixture. Every directory in it —drift-repo,test-repo,empty-repo,arch-repo,sdlc-core,parity-test— is built by anfs.ensureDirin the e2e that uses it, and most are removed again inafterAll. Nothing under the path has ever been tracked.They survive only when a run is interrupted before its teardown, and then sit as untracked forever. Today's working tree carried
drift-repo/evolith.yamland adrift-history.jsonstamped2026-08-21T20:36, left by a run that died beforeafterAll.That is the exact shape the root
.gitignorealready warns about two entries up — CLI artefacts that "se commitearon por accidente una vez y fosilizaron como si fueran taxonomia". This closes the same hole one directory over.The comment names the trap in the other direction too: an authored fixture dropped in here would be ignored silently, so it belongs in
test-project/or needs a deliberate force-add.Verified
Recreated the scratch tree (
drift-repo/evolith.yaml+.evolith/drift-history.json) in a clean worktree:git status --porcelainreports onlysrc/sdk/cli/.gitignoregit check-ignore -vattributes it to the new rule, not to a broader accidentsrc/sdk/cli/test/are untouched by the pattern — it is scoped totest/fixtures/🤖 Generated with Claude Code