Repository navigation
Preserve runtime dataset settings when reloading metadata caches - #3298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading a metadata cache could replace the active dataset configuration after registration. A requested batch size of 4 could therefore become the cached batch size of 2 before sampler construction; repeats and dataset activation settings were affected too.
Keep cached configuration on the metadata backend for configuration validation, without publishing it into the live registry. Apply this consistently to discovery, Hugging Face, Parquet, Webshart, and caption metadata backends. Regression tests use the real registry and a registered Webshart backend to verify sampler batch sizing.
Validation:
.venv/bin/python -m unittest -v -f tests.test_metadata_runtime_config tests.test_metadata_backend tests.test_factory_edge_cases tests.test_factory_caption_backend tests.test_webshart_backend tests.test_huggingface_metadata_backend— 213 tests passed..venv/bin/python -m unittest discover -v -f tests/— 7,110 tests completed successfully, with 323 skips.