Skip to content

fix: rv-live should honor the BMP peer A flag #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pforemski merged 1 commit into from
Sep 4, 2026
Merged

fix: rv-live should honor the BMP peer A flag #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stages/rv-live/openbmp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ func (s *RvLive) processRecord(record *kgo.Record) error {
return fmt.Errorf("dangling bytes after BGP message: %d/%d", n, len(bm.BgpData))
}

// the peer A flag announces the legacy 2-byte AS_PATH encoding (RFC 7854/4.2)
// NB: trust it only when set; routeviews never sets it, and assuming 4-byte
// ASNs on a clear flag would defeat --guess-asn
if bm.Peer.Is2ByteAS() {
m.ParseAS4 = -1
}

// set time
if !bm.Peer.Time.IsZero() {
m.Time = bm.Peer.Time
Expand Down
Loading