-
Notifications
You must be signed in to change notification settings - Fork 1
Update/20260722 record dtos #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0ea1c3
Fix DTO & Mocks v1
bitai-cs 7823510
File version updated
bitai-cs baead2a
Fix tests
bitai-cs fc5b912
Test with Persistence Data
bitai-cs f54992a
fix Tests
bitai-cs 3fa6d67
Remove deprecated mocks
bitai-cs e88ea51
Fix version
bitai-cs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
235 changes: 119 additions & 116 deletions
235
adapters/Bitai.LDAPHelper.LdapAdapters.LdapHelperMock/LdapData/MockLdapDataSeeder.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 0 additions & 120 deletions
120
adapters/Bitai.LDAPHelper.LdapAdapters.LdapHelperMock/MockLdapConnectionAdapter.cs
This file was deleted.
Oops, something went wrong.
40 changes: 0 additions & 40 deletions
40
adapters/Bitai.LDAPHelper.LdapAdapters.LdapHelperMock/MockLdapConnectionFactoryAdapter.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The mock now handles CN filters only when the filter contains
(Name=...)and then looks up the case-sensitiveNamekey, but seeded users and groups still addcnand lowercasename; those entries therefore return no match for name searches in the persistent mock.Triggers: When the persistent mock is used to search seeded users or groups by the normal LDAP
cnattribute.Suggested fix: Support
(cn=...)and read the actualcnattribute, or normalize mock attribute names case-insensitively and consistently seed the same attribute.