Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1964.
A connected but silent pool leaves the receive loop retrying zero-byte timeouts forever. Add a three-minute deadline for receiving a complete line and clear partial data on timeout, allowing the existing retry and fallback logic to run. Short gaps remain valid.
Validation: 105 C unit tests passed; four new cases failed before the fix. Python coverage is pushed, with 138 unit tests passing. All nine fallback cases and 37 mining phases passed on Gamma-02 with this firmware. The 15-second silence retained the same connection; sustained silence reached stable fallback mining in 732 seconds and recovered primary after replies resumed. All original settings and fresh shares were restored without a restart.
Python regression: johnny9/mining-qa-testcode@a5bec34