Skip to content

fix(ci): a commit must not cancel another commit's run #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catomean merged 1 commit into from
Sep 11, 2026
Merged

fix(ci): a commit must not cancel another commit's run #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,20 @@ on:
branches: [main]
pull_request:

# On a branch the newest push is the only one that matters, so cancel the rest.
#
# On main the group is keyed per COMMIT. A commit cancelling a DIFFERENT
# commit's run breaks deployment, because every deploy path keys off that run:
# one that waits for CI to pass on the commit finds a cancelled run and stops,
# and one chained on `workflow_run` sees conclusion=cancelled and skips.
# auto-merge also re-arms CI with a dispatch, which under a single
# group-per-branch cancels the push run for the SAME commit.
#
# Measured 2026-09-11 across the fleet: 28 of 39 ci.yml files had this shape.
# fleetcrown stranded four merges silently (main green, nothing red, the box
# serving the previous build); hirnli failed its deploy loudly at the wait step.
concurrency:
group: ci-${{ github.ref }}
group: ci-${{ github.ref }}-${{ github.ref == 'refs/heads/main' && github.sha || 'branch' }}
cancel-in-progress: true

jobs:
Expand Down