docs: 22 vs 23 — the release notes contradicted themselves on the kill count - #415
Merged
Merged
Conversation
…l count #413 was supposed to correct "two kills" to the real figure. It corrected the PR DESCRIPTION on GitHub and left the FILES saying 22, while the paragraph added in the same branch says 23 OOM kills four paragraphs later. The release notes therefore state two different counts for the same event, in the document whose purpose was fixing a miscount. ⛔ THE NUMBER IS 23: journalctl -u hazync-bridge | grep -c "Failed with result 'oom-kill'" = 23, and systemctl show -p NRestarts agreed at 23 before the explicit stop reset it to 0. 22 was the count when the branch was first written, at 06:35; one more kill landed at 06:47 before the bridge was stopped at 06:54. Also corrects STATUS.md's "one alert each" — there are TWO hooks (OnFailure= and ExecStopPost=--crash), so 23 kills produced ~36 sends, not 23. ⚠ Caught only by READING the file on main rather than grepping for the string I expected to find. I verified the PR body and assumed the files followed.
… its date Two more stale figures the same sweep found, folded in here rather than opening a fourth docs PR. ⛔ STATUS.md said the bridge hits its cap at h=798,257 (108.06M UTXOs). That was the FIRST ceiling encounter. It reached 800,257 at 01:24 with 112.1M coins and never got past it, so 800,257 is the real ceiling — the release notes already said so and STATUS.md did not. ⚠ The frontier figure 93,333 is kept, not updated, but now carries its measurement date. It was accurate on 2026-09-18 and the board has since passed 95,000. STATUS.md states up front that board figures are a dated snapshot; the release notes carry no such caveat, so an undated number there reads as current when it is not. The ~322,000 blocks of runway is unaffected either way: the bundles end at 418,268 and the frontier moving up slightly shortens it by the same slight amount.
The fourth inconsistent figure in the document I am correcting for inconsistent figures. STATUS.md was fixed in the previous commit and the release notes were not. TWO hooks fire on every kill: OnFailure=hazync-alert@%n.service (23 'FAILED' sends) and ExecStopPost=+hazync-alert.sh --crash (13 'CRASHED' sends) = 36, with 10 further suppressed by the script's cooldown. So 23 kills did NOT produce 23 alerts. ⚠ I reported this count three times tonight (0, then 23, then 36) before getting it right. 0 came from grepping for --crash when the OnFailure template uses --unit; 23 counted only one of the two hooks. 36 is from a full breakdown of every distinct alert line, which is the only reason I trust it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#413 was meant to correct "two kills" to the real figure. It corrected the PR description and left the files saying
**22 kills**— while the paragraph added in that same branch says 23 OOM kills four paragraphs later.So the release notes currently state two different counts for the same event, in the document whose entire purpose was fixing a miscount.
The number is 23
22 was correct when the branch was written (06:35). One more kill landed at 06:47, before the bridge was stopped at 06:54.
Also fixes an undercount in
STATUS.mdIt said "one alert each". There are two hooks —
OnFailure=hazync-alert@%n.serviceandExecStopPost=…--crash— so 23 kills produced ~36 sends, not 23.How it got through
I verified the PR body on GitHub and assumed the files had followed. They hadn't —
gh api -X PATCH .../pulls/413edits the description, not the diff. Caught only by reading the file onmaininstead of grepping for the string I expected.Blocks the v0.21.7 tag — everything else is ready (release checkout at
ec25a20, 0 dirty, 0 open non-draft PRs).