Skip to content

fix(dispatch-check): four hardening items from sable review - #27

Merged
bitswell merged 1 commit into
mainfrom
loom/dispatch-check-followups
Apr 19, 2026
Merged

bitswell merged 1 commit into
mainfrom
loom/dispatch-check-followups

Conversation

@bitswell

Copy link
Copy Markdown
Owner

Summary

Four small hardening items from Sable's review of #23 (dispatch-check).
All graded non-blocking; all localized to dispatch-check.

  1. Trailer-validate tripwire: spy on the stubbed handler's emit; fails if anyone grows the ctx surface.
  2. Underscore-in-repo-name: negative test encoding the parser's commitment on the slug separator.
  3. Bare-commit case: fixture with git init + initial commit only; asserts rule Phase 3: Lifecycle + workflow tools (orchestrator capabilities) #3/Phase 4: MCP + CLI runtime adapters #4 cascade is readable.
  4. path.relative defence: rule Phase 1: tool registry and role scoping #6 rejects Scope entries that resolve outside the worktree; traversal test.

Source

Planned as bitswell/bitswell task/bitswell-core/dispatch-check-followups (seed commit 17fd279) from bitsweller issue f19b785.

Test plan

  • All existing tests pass (401 total)
  • 4 new tests added and passing
  • tsc --noEmit clean

Bitsweller-Issue: f19b7853cd10360997c1a116dff0e85dde290876

Closes bitswell/bitswell f19b785 via task branch
task/bitswell-core/dispatch-check-followups.

1. Tripwire test pinning trailer-validate handler's ctx surface
   (rule #4 composition).
2. Negative test for underscore-in-repo-name parse behaviour
   (rule #1 commitment).
3. Bare-commit worktree test where HEAD has no LOOM trailers at
   all (rule #3 / #4 cascade readability).
4. path.relative defence in rule #6 rejecting Scope entries that
   resolve outside the worktree, plus a traversal test.

Bitsweller-Issue: f19b7853cd10360997c1a116dff0e85dde290876
Agent-Id: moss
Session-Id: bitswell-core-impl-dispatch-check-followups
@bitswell
bitswell merged commit faa178a into main Apr 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants