v1.3.0 - #60
Draft
wayneeseguin wants to merge 15 commits into
Draft
Conversation
- Extract network name from deployment manifest per instance group - Use VM's actual network for DNS name and credential generation - Fall back to BOSH_NETWORK env var when network info unavailable - Enables multi-network BOSH deployments for service instances
Add proper mutex synchronization to fix race conditions detected by Go's race detector in CI. Fixes thread-unsafe lazy initialization in vault client, unprotected global logger access, and serializes calls to spruce library which has thread-unsafe global state.
- Update golang.org/x/crypto from v0.41.0 to v0.43.0 Fixes GO-2025-4116: Potential DoS in ssh/agent - Update hashicorp/vault replace directive from v1.20.3 to v1.21.0 Fixes GO-2025-4071: DoS when processing JSON - Update Go version from 1.25.1 to 1.25.5 Fixes GO-2025-4175, GO-2025-4155: crypto/x509 vulnerabilities
Update vault client to use TuneMountAllowNil API instead of deprecated TuneMount to fix staticcheck SA1019 warning after vault v1.21.0 upgrade.
…ork-service-binding-main feat(binding): support dynamic network selection for service bindings
Update the network extraction method to reduce the bosh API calls
parseDuration() swallowed time.ParseDuration errors via blank identifier, causing bare-integer YAML values like `interval: 3600` to silently fall to 5-minute default. Now handles bare numeric seconds, logs parse failures, unifies default to 1 hour, fixes data races on GetInterval/UpdateInterval, corrects Vault precedence so env var overrides persisted settings, and uses read-modify-write for Vault settings persistence.
Return nil instead of empty ReconcilerAdapter when BOSH is unavailable, preventing misleading 0s interval via API. Add robust duration parsing to settings endpoint accepting both Go durations and bare numeric seconds.
Cover Go duration strings, bare integer seconds, bare floats, empty input, and invalid formats. Verify bare integer 3600 equals Go duration 1h.
Change default interval examples from 5m to 1h. Document accepted formats (Go duration, bare seconds) and config precedence: env var > Vault > YAML > default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: v1.3.0