Bump docker/login-action from 3 to 4 - #543
Conversation
dependabot
Bot
added
dependencies
Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3...v4) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2602623 to
3b2396a
Compare
blooop
left a comment
blooop
left a comment
There was a problem hiding this comment.
v4 is a runtime and packaging major — Node 24 as the default runtime and a
switch to ESM (docker/login-action#929,
#927) — rather than a change
in what the action does. Nothing in its interface moved under us: registry,
username and password are the only three inputs this workflow passes, and
all three are still declared in v4's action.yml, undeprecated and with the
same meanings.
The Node 24 default needs runner v2.327.1+. The only job that uses this action
is prebuild, which runs on ubuntu-latest and ubuntu-24.04-arm — both
GitHub-hosted and current, so there is no runner here to strand.
Two things worth recording rather than leaving implicit:
- PR CI does not exercise this.
devcontainer-prebuild.ymltriggers on
pushes tomainunder a.devcontainer/**path filter plus the workflow file
itself. That filter includes this file, so the merge tomainis the first
real run of the GHCR login — and the merge commit will trigger it, which is
the verification. A green tick on this PR says nothing about the changed line. - The
rustfailure on the original head was not this bump. It was
the_stages_account_for_no_more_than_the_totalcomparing a sum ofround6'd
stage seconds against a separatelyround6'd total with an exact<=, which
rounding alone can trip (0.030157 + 0.030099against0.060256). Fixed in
#545; this branch is rebased
onto it rather than re-rolled until the dice came up green.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1 participant
Bumps docker/login-action from 3 to 4.
Release notes
Sourced from docker/login-action's releases.
... (truncated)
Commits
dbcb813Merge pull request #1051 from docker/dependabot/npm_and_yarn/aws-sdk-dependen...5bcb015[dependabot skip] chore: update generated contentb30b2f2build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 up...9087f1eMerge pull request #1057 from docker/dependabot/npm_and_yarn/js-yaml-5.2.20009830[dependabot skip] chore: update generated content2325523build(deps): bump js-yaml from 5.2.1 to 5.2.24ec1d4aMerge pull request #1056 from docker/dependabot/npm_and_yarn/postcss-8.5.225fc99baMerge pull request #1053 from docker/dependabot/github_actions/aws-actions/co...e512bd5Merge pull request #1052 from docker/dependabot/github_actions/codeql-actions...a146c91Merge pull request #1059 from crazy-max/harden-buildx-scope-pathsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)