Fix auto-release: dispatch publish instead of a reusable-workflow call - #26
Merged
Conversation
The just-merged fix (calling python-publish.yml's deploy job directly via workflow_call) avoided needing a PAT, but broke PyPI's OIDC trusted publishing: PyPI does not support trusted publishing from reusable/called workflows and rejected the token, confirmed by gh-action-pypi-publish's own warning annotation on the run (https://docs.pypi.org/trusted-publishers/troubleshooting/#reusable-workflows-on-github). Fix: python-publish.yml goes back to being a plain, directly-triggered top-level workflow (workflow_call trigger removed). auto-release.yml instead dispatches it via `gh workflow run` (workflow_dispatch) using the default GITHUB_TOKEN -- workflow_dispatch is the documented exception to GitHub Actions' "GITHUB_TOKEN can't trigger other workflows" rule, so this needs no PAT either. Also: gate the "already done" check on whether the version is actually on PyPI (not just whether a GitHub Release exists for it) -- today's v0.4.0 already has a release from the earlier partial failure, but never reached PyPI, and the old exists-check would have skipped it forever. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FPDh1XcpTJT48Tw27fD7Ms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.