Repository navigation
fix(bytecompiler): continue to an outer label of a multi-labelled loop - #5640
Open
thelastbackspace wants to merge 2 commits into
Open
thelastbackspace wants to merge 2 commits into
thelastbackspace wants to merge 2 commits into
Conversation
With `a: b: for (...)` only `b` was attached to the loop's jump info, so `continue a` resolved to the labelled statement for `a` and jumped back to its start, re-running the loop initialiser and never terminating. Resolve such a label through the chain of labelled statements to the loop they label. Fixes boa-dev#5633
github-actions
Bot
added
Waiting On Review
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
===========================================
+ Coverage 47.24% 63.09% +15.85%
===========================================
Files 476 536 +60
Lines 46892 60552 +13660
===========================================
+ Hits 22154 38206 +16052
+ Misses 24738 22346 -2392 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HalidOdat
reviewed
Nov 10, 2026
| /// A loop can have more than one label (`a: b: for (;;)`), but only the innermost one is | ||
| /// attached to the loop's own jump info; the outer ones are separate labelled-statement infos | ||
| /// pushed right before it. A `continue` to any of them has to continue the loop itself. | ||
| fn continue_target(&self, label: Sym) -> Option<usize> { |
Member
There was a problem hiding this comment.
Suggestion: consider adding the spec steps/link here which relate to this code.
Author
There was a problem hiding this comment.
Added in 1118fdf: links to LabelledEvaluation and LoopContinues, plus a note on how the label set « a, b » reaches the loop, which is why continue a has to continue it just like continue b.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5633.
With
a: b: for (...), only the innermost label (b) ends up on the loop's jump info.agets its own labelled-statement info just outside it. Socontinue amatched that labelled info and jumped back to the start of the labelled statement. That re-ran the loop initialiser (i = 0), and the loop never finished.continue bwas fine. The title of the issue says it's the second label, but on main it's actually the outer one (continue a) that hangs.It changes the following:
continue <label>now resolves its target up front. If the label belongs to a labelled statement, it walks the chain of directly nested labelled statements down to the loop they label and continues that loop. Anything that isn't a loop falls back to the old behaviour (that's an early error anyway).for,whilewith three labels, andfor-ofwith an inner loop. Each one has a guard counter, so without the fix the test fails instead of hanging.cargo test -p boa_engine --libpasses. I also checkeddo-while,for (let ...)with closures plustry/finally, andbreakto an outer label by hand.