Repository navigation
fix(translations): stop translating two admin messages twice - #3843
Merged
bobvandevijver merged 1 commit intoOct 25, 2026
Merged
Conversation
The secure preview link in the content edit dropdown passed an already translated label to macro.buttonlink(), which translates it again. The login-required flash message was translated in the "security" domain in AuthenticationEntryPointRedirector, and _flash_messages.html.twig translated the result again in "messages". The second lookup uses the translated text as a key, so it is reported as a missing translation, and php-translation's auto_add_missing_translations writes it into the project's translation files. Pass the translation key to the macro, and add the flash message as an untranslated key like the other backend flash messages. The translation catalogue changes are made separately for 6.2.
Vondry
force-pushed
the
fix/double-translated-messages-6.1
branch
from
October 25, 2026 07:52
721fbb4 to
ffd12e3
Compare
bobvandevijver
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmits #3834 (reverted in #3842) with code changes only. All translation catalogue changes are in #3844 for 6.2.
Two admin messages were translated twice. The second lookup used the already translated text as a key, so with
auto_add_missing_translationsenabled, junk units (e.g. a Czech sentence as a key) were written into the project's translation files._buttons.html.twig): passed'action.preview_secure_share'|transtomacro.buttonlink(), which translates the label again. It now passes the key.AuthenticationEntryPointRedirector): translated insecurity, then again by_flash_messages.html.twig. It's now added as an untranslated key, like the other backend flash messages.On 6.1 the login message is now read from the existing
messagesunits: en, fr, nl and sk are unchanged, cs and ru use the slightly differentmessageswording, and de falls back to English, asmessages.de.xlfhas no unit for it.