bivariate Poisson family - #50
Open
marius-oetting wants to merge 195 commits into
Open
Conversation
PR: Merge Devel to Master
…th gamboostLSS:::
fix(copula_families): compute ngradient_p and ngradient_theta correctly for all marginal cases continuous_continuous condition was inverted, making the copula correction dead code and get_marginal_logpdf differences are only valid where the likelihood decomposes as log(c) + log(f1) + log(f2). Now non-continuous cases differentiate the dispatched loglik directly chore(copula_families): drop qfuns
fix(package): import dbinom from stats - needed by the Bernoulli case in get_marginal_logpdf
…vignette building
Add copula functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi gamboostLSS-Team,
I have implemented the bivariate Poisson distribution as a new families-object within your package for a project which is currently under review. One referee suggested to make a pull request here to contribute this family to gamboostLSS. The code for the family can be found in my repository "match-fixing-warning-systems" in the file "BivPoisFamily.R". I'd be happy to hear what you think about this! :-)
Best
Marius