Repository navigation
fix: show a size that rounds up to 10 without a decimal place - #640
Merged
Merged
Conversation
Owner
|
that is an interesting edge case. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
human_readable_numberprints one decimal place for sizes under 10 units and none from 10 up. The< 10check uses integer division, but the decimal branch rounds with{:.1}, so a size from 9.95 to 9.99 units passes the check and then rounds up to10.0:The same happens at every unit (
10.0Mi,10.0G, ...). Those sizes now print as10Ki/10K, the same as the sizes just above them. Everything else is unchanged.Tests: new cases in
test_human_readable_number_sifail before the change (left: "10.0Ki",right: "10Ki") and pass after;cargo test(all suites) andcargo fmt --checkpass.AI assistance: I used an AI coding assistant to help find and write this change. I reviewed the code and tests and ran them myself.