ci: Fix docs-only detection in compute-ci-level - #2394
Open
gursewak1997 wants to merge 2 commits into
Open
Conversation
gursewak1997
force-pushed
the
ci-skip-md-docs-v2
branch
from
August 19, 2026 19:27
728da27 to
5879e2e
Compare
There was a problem hiding this comment.
Pull request overview
Fixes docs-only CI detection so diff failures no longer silently skip heavy tests.
Changes:
- Adds sparse checkout for pull request events.
- Separates diff retrieval from classification and rejects empty output.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The previous attempt (merged in bootc-dev#2391) failed silently because compute-ci-level had no checkout step, so gh pr diff could not infer the repository and produced empty output. The pipe into grep swallowed the error, setting docs_only=true for all PRs. Fix by adding a sparse checkout for PR events, separating the gh pr diff fetch from the grep so failures abort via set -euo pipefail, and guarding empty output explicitly. Assisted-by: AI Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
ci-skip-md-docs-v2
branch
from
August 19, 2026 19:41
5879e2e to
5d19d32
Compare
cgwalters
previously approved these changes
Aug 19, 2026
cgwalters
enabled auto-merge (rebase)
August 19, 2026 20:32
`priv-integration.sh` was hanging at the chunkah step where we mount an entire image inside a podman container. In the logs I can see `overlay.mount_program=/usr/local/bin/fuse-overlayfs` which might be causing the test to timeout since fuse-overlayfs is pretty slow and the image has tons of layers. Switch to native overlay diff which should hopefully fix the issue Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Collaborator
|
Hmm.. Test Install still failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt (merged in #2391) failed silently because compute-ci-level had no checkout step, so gh pr diff could not infer the repository and produced empty output. The pipe into grep swallowed the error, setting docs_only=true for all PRs.
Fix by adding a sparse checkout for PR events, separating the gh pr diff fetch from the grep so failures abort via set -euo pipefail, and guarding empty output explicitly.