Perform file tokenization in python - #437
Open
WhatAmISupposedToPutHere wants to merge 1 commit into
Open
Conversation
Member
|
Hi, yes I'm down for this. But it completely breaks file rendering. All files appear as a single empty line. Agreed? Reproducer: |
Avoid going through bash and perl just to run some regexes. No existing project files override those functions, so no functionality is lost. update.py speed comparison on a clean import of arm-trusted-firmware before: real 21m53.464s user 49m20.962s sys 30m0.147s after: real 21m5.273s user 44m39.705s sys 26m11.396s Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
WhatAmISupposedToPutHere
force-pushed
the
update-faster
branch
from
August 21, 2026 20:21
9ae8062 to
3016e62
Compare
Author
|
Oops, sorry about that, it appears that i failed at rebasing this from my dev branch. Should render correctly now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid going through bash and perl just to run some regexes. No existing project files override those functions, so no functionality is lost.
update.py speed comparison on a clean import of arm-trusted-firmware
before:
real 21m53.464s
user 49m20.962s
sys 30m0.147s
after:
real 21m5.273s
user 44m39.705s
sys 26m11.396s