Skip to content

Fall back to motherboard serial in run reporting - #70

Merged
rodchristiansen merged 1 commit into
mainfrom
fix/serial-fallback
Oct 29, 2026
Merged

rodchristiansen merged 1 commit into
mainfrom
fix/serial-fallback

Conversation

@rodchristiansen

@rodchristiansen rodchristiansen commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Run summaries now resolve serialNumber from Win32_BIOS, then Win32_BaseBoard when BIOS is blank, Default String, or System Serial Number. This replaces the independent registry lookup so reporting uses the firmware serial sources used for enrollment.

Values are trimmed, placeholder checks ignore case, and a valid BIOS serial avoids the motherboard query. Lookup failures remain best-effort and two unusable sources retain the existing empty serial representation. Adds System.Management 10.0.12 for WMI access.

Validation: Windows CI passed both x64 and ARM64 CLI, GUI and MSI builds; all 225 core unit tests passed on x64. The 15 focused resolver tests also pass on macOS (.NET 10). Real firmware validation and a signed release remain deployment gates.

Risk: medium — changes reported hardware identity on devices with invalid BIOS serials and adds a WMI dependency; no release or deployment in this PR.

Closes #69

@rodchristiansen
rodchristiansen merged commit b1ad8bd into main Oct 29, 2026
2 checks passed
@rodchristiansen
rodchristiansen deleted the fix/serial-fallback branch October 29, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report a usable motherboard serial when BIOS serial is a placeholder

1 participant