Full seed data for new bases - #2899
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 74.19% 74.20% +0.01%
==========================================
Files 330 330
Lines 25383 25389 +6
Branches 2533 2534 +1
==========================================
+ Hits 18833 18841 +8
+ Misses 6500 6498 -2
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Demo reseeds must use demo-tenant Auth0 role IDs instead of staging IDs.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Expands seed and fake-data generation from four to eight bases, with updated integration-test expectations and Auth0 mappings.
Changes:
- Adds permissions, groups, roles, and seed data for four bases.
- Expands fake-data generation and reseeding support.
- Updates integration-test counts and adds
CurrentUserrepresentation.
File summaries
| File | Summary |
|---|---|
back/test/auth0_integration_tests/test_operations.py |
Updates seeded resource counts. |
back/test/auth0_integration_tests/test_cron.py |
Covers the expanded base set. |
back/minimal.sql |
Adds new base access seed data. |
back/boxtribute_server/cron/reseed_db.py |
Adds Auth0 role mappings. Critical (3 votes): staging role IDs are used where demo role IDs are selected for demo reseeds. |
back/boxtribute_server/cron/data_faking.py |
Expands fake-data generation to eight bases. |
back/boxtribute_server/auth.py |
Adds CurrentUser representation output. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+159
to
+163
| "base_100000002_coordinator": "rol_PfOXCc0AAnhmT4tY", | ||
| "base_100000002_external_free_shop_checkout": "rol_K0yifOt6v3FT4mJa", | ||
| "base_100000002_free_shop_volunteer": "rol_NbOMIpwf7eacyCh3", | ||
| "base_100000002_label_creation": "rol_1eDGSg6Srva6aupa", | ||
| "base_100000002_warehouse_volunteer": "rol_CkjUNGslzCy6V9GF", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/GJt1PXBF