Repository navigation
fix(decode): correct image size sniffing for WebP, JPEG and oriented PNG - #1
Merged
Merged
Conversation
- Read lossless WebP (VP8L) dimensions after the 0x2f signature byte; they were read 3 bytes late, so lossless WebPs decoded distorted. - Slide the JPEG marker scan past the first 256 KB so metadata-heavy files (ICC profiles, extended XMP) are no longer rejected. - Never force both resize sides in decodeImage: Chromium applies PNG EXIF orientation and WebKit does not, so forcing both stretched rotated PNGs. Fitting images decode as-is; larger ones pass a width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resizeWidth, andcapBitmaptrims any overshoot.Verification
npm test: 321/321 pass (regression tests added for each bug, confirmed failing before the fix).npx playwright test: 258 passed, 1 failed (load-and-input"sample image loads and traces" on iPad). It passed 3/3 when rerun alone, so it looks flaky under the full parallel run.