You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A pre-existing release test flake is blocking the Grok Build PR, #2876. Its 20 ms deadline probe shares an HTTP server and request counter with a later 503 assertion, so a late aborted request can inflate that assertion. Failing CI run.
What
Give 404-then-200 publication, immediate 503 rejection, and persistent-404 deadline expiry independent tests and servers. Assert the SDK request paths, exactly one 503 request, and an actual 404 retry before expiry. Advance only Date.now for the deadline case, keeping real HTTP requests and network timers. The existing stalled-request test remains; production code is unchanged.
How
Validated 154 root unit tests, 20 runs of the four HTTP scenarios totaling 80 test executions, tooling typecheck, formatting, and lint.
Summary by cubic
Fixes a flaky release test by giving each SDK publication probe its own HTTP server and request counter, so a late aborted request from one scenario no longer inflates the 503 assertion's request count in scoped-release.test.ts.
Splits the shared 404-then-200 publication, immediate-503 rejection, and deadline-expiry scenarios into separate tests.
Asserts exact request paths, exactly one 503 request, and an actual 404 retry before expiry.
Mocks only Date.now for the deadline case, keeping real HTTP requests and network timers.
Leaves production code unchanged.
Written for commit ed36d23. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pre-existing release test flake is blocking the Grok Build PR, #2876. Its 20 ms deadline probe shares an HTTP server and request counter with a later 503 assertion, so a late aborted request can inflate that assertion. Failing CI run.
What
Give 404-then-200 publication, immediate 503 rejection, and persistent-404 deadline expiry independent tests and servers. Assert the SDK request paths, exactly one 503 request, and an actual 404 retry before expiry. Advance only
Date.nowfor the deadline case, keeping real HTTP requests and network timers. The existing stalled-request test remains; production code is unchanged.How
Validated 154 root unit tests, 20 runs of the four HTTP scenarios totaling 80 test executions, tooling typecheck, formatting, and lint.
Summary by cubic
Fixes a flaky release test by giving each SDK publication probe its own HTTP server and request counter, so a late aborted request from one scenario no longer inflates the 503 assertion's request count in
scoped-release.test.ts.Date.nowfor the deadline case, keeping real HTTP requests and network timers.Written for commit ed36d23. Summary will update on new commits.