Repository navigation
LTS-5442: harden selenium sample (Semgrep pin, jest lockfile, web-security flag, credential + CLI-verify guidance) - #7
Merged
Conversation
…drop --disable-web-security, credential + CLI-verify guidance) - LTS-5458: pin returntocorp/semgrep:1.166.0 by digest - LTS-5465: stop ignoring package-lock.json, commit jest/package-lock.json - LTS-5472: remove --disable-web-security from all 5 Chrome option lists - LTS-5452: browserstack-load.yml comment points at env vars, warns against inlining the key - LTS-5479: validate the product index before building the CSS selector - README: zip note, CLI signature-verify step, fix swapped Linux x86/arm links Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
MohitSinghBS
approved these changes
Oct 28, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes from the LTS-5442 scan of this sample repo.
1.166.0@sha256:c180f0c9…)package-lock.jsonno longer gitignored;jest/package-lock.jsoncommitted (npm audit: 0 vulnerabilities)--disable-web-securityremoved from java, junit-4, junit-5, testng and serenity-cucumberbrowserstack-load.ymlcomment now says to useBROWSERSTACK_USERNAME/BROWSERSTACK_ACCESS_KEYenv vars (the CLI lets them override the placeholders) and not to paste a real key into the fileStepDefsrejects a non-digit product index before building the CSS selectorAlso in every README: the CLI download is a zip, a new step to verify the CLI signature (macOS
codesignTeamIdentifierYQ5FZQ855D, Windows Authenticode), and the swapped Linux x86/ARM download links are fixed.The matching BE sample zips are updated in browserstack/load-testing-backend#3604.
🤖 Generated with Claude Code