Skip to content

Show launcher default-switch feedback beside the selected app - #213

Merged
bryanroscoe merged 5 commits into
mainfrom
fix/launcher-feedback-212
Oct 23, 2026
Merged

bryanroscoe merged 5 commits into
mainfrom
fix/launcher-feedback-212

Conversation

@bryanroscoe

@bryanroscoe bryanroscoe commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

The Launcher tab put switch results below the full list and hid them on refresh errors. Set-as-default outcomes now stay beside the selected launcher, with a visible stale-state note if refresh fails and recoverable diagnostic text when clipboard access is refused. Late replies after leaving the device page are ignored. Addresses the feedback report in #212; actual device launcher behavior remains unverified.

Attached simulated screenshots and15.84-second video cover success, refusal, no-op, refresh failures and interruptions. They were captured at fccb8da03195218f6f2ca3ed1723426585744214 on a macOS host using Playwright desktop-browser fixtures, with no real-device operation. The existing attachment comment is retained; no duplicate upload was made.

The evidence-only follow-up bd3fc7b removes duplicate newly committed media after all eleven existing attachments were downloaded and verified byte-for-byte. Original Git history, capture hashes, and attachment URL/hash manifest preserve provenance. Runtime, safety, app identity and gallery files are unchanged by that follow-up.

Completed validation: npm run test:launcher-feedback passes all 11 cases at the evidence-migration head, and manifest hashes/sizes match all 11 original Git blobs. Earlier check/build and exact-headCI were green at fccb8da; the final reconciliation head has completed fresh CI. This PR remains draft and merge-blocked pending explicit approval; the PNG feedback is not merge approval.

Current reconciliation revision: cc5c2ff8b65adc5594d1315bcd196e8072aea528, a normal merge of 9dc4959ddfedc4f44935607c9e1bc28757d5a22c into the existing fix branch. It preserves current main’s curated-list correction and documentation, with both generated galleries refreshed. The original attached feedback captures retain their original fccb8da revision and earlier curated-list background; the feedback behavior is unchanged. No duplicate media upload or comment was made.

At the reconciliation head, 615 workspace Rust tests passed (one existing ignored), fmt/Clippy passed, Svelte check found 0 errors/0 warnings, production build succeeded, and all 11 feedback cases plus generic HOME/curation launcher regressions passed. Merge-revision CI passed all six jobs. The PR remains draft and is not authorized for final merge.

Final review head: 82dde096ec6da6b80cc52ca4dbc2e544617d299c. The only changes after locally tested merge revision cc5c2ff8b65adc5594d1315bcd196e8072aea528 are the two generated gallery GIFs: independent review caught an Overview frame mislabeled as Launcher during the first capture, and an isolated recapture corrected it in both themes. Source/runtime/test files are byte-identical to the locally validated merge revision. Final-head CI completed successfully with all six jobs green; earlier reconciliation CI also passed. Independent review approved the final exact head after decoding both committed gallery Launcher slides. No attachment upload or new comment was repeated.

@bryanroscoe

Copy link
Copy Markdown
Owner Author

Lots of pngs on this that should have been uploaded to the pr via the gh pr artifacts thingy not this.

@bryanroscoe

Copy link
Copy Markdown
Owner Author

Evidence re-posted as attachments. The earlier links used repo-relative paths, which 404 from a PR page. Captured at fccb8da; write-up: v2/evidence/launcher-feedback-212/README.md.

launcher-feedback-simulated.webm

cancel-takeover-simulated.png

channel-refresh-simulated.png

current-refresh-simulated.png

failure-refresh-simulated.png

failure-simulated.png

interrupted-simulated.png

list-refresh-simulated.png

noop-simulated.png

success-simulated.png

unverified-simulated.png

@bryanroscoe
bryanroscoe marked this pull request as ready for review October 23, 2026 03:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T03:44:57.201780Z 0703100 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bryanroscoe
bryanroscoe merged commit 92570bb into main Oct 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant