Repository navigation
Show launcher default-switch feedback beside the selected app - #213
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Owner
Author
|
Lots of pngs on this that should have been uploaded to the pr via the gh pr artifacts thingy not this. |
Owner
Author
|
Evidence re-posted as attachments. The earlier links used repo-relative paths, which 404 from a PR page. Captured at launcher-feedback-simulated.webm |
Keeps both the launcher-feedback and TV Recommendations test steps, scripts and evidence paths, and regenerates the desktop galleries.
bryanroscoe
marked this pull request as ready for review
October 23, 2026 03:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










The Launcher tab put switch results below the full list and hid them on refresh errors. Set-as-default outcomes now stay beside the selected launcher, with a visible stale-state note if refresh fails and recoverable diagnostic text when clipboard access is refused. Late replies after leaving the device page are ignored. Addresses the feedback report in #212; actual device launcher behavior remains unverified.
Attached simulated screenshots and15.84-second video cover success, refusal, no-op, refresh failures and interruptions. They were captured at
fccb8da03195218f6f2ca3ed1723426585744214on a macOS host using Playwright desktop-browser fixtures, with no real-device operation. The existing attachment comment is retained; no duplicate upload was made.The evidence-only follow-up
bd3fc7bremoves duplicate newly committed media after all eleven existing attachments were downloaded and verified byte-for-byte. Original Git history, capture hashes, and attachment URL/hash manifest preserve provenance. Runtime, safety, app identity and gallery files are unchanged by that follow-up.Completed validation:
npm run test:launcher-feedbackpasses all 11 cases at the evidence-migration head, and manifest hashes/sizes match all 11 original Git blobs. Earlier check/build and exact-headCI were green atfccb8da; the final reconciliation head has completed fresh CI. This PR remains draft and merge-blocked pending explicit approval; the PNG feedback is not merge approval.Current reconciliation revision:
cc5c2ff8b65adc5594d1315bcd196e8072aea528, a normal merge of9dc4959ddfedc4f44935607c9e1bc28757d5a22cinto the existing fix branch. It preserves current main’s curated-list correction and documentation, with both generated galleries refreshed. The original attached feedback captures retain their originalfccb8darevision and earlier curated-list background; the feedback behavior is unchanged. No duplicate media upload or comment was made.At the reconciliation head, 615 workspace Rust tests passed (one existing ignored), fmt/Clippy passed, Svelte check found 0 errors/0 warnings, production build succeeded, and all 11 feedback cases plus generic HOME/curation launcher regressions passed. Merge-revision CI passed all six jobs. The PR remains draft and is not authorized for final merge.
Final review head:
82dde096ec6da6b80cc52ca4dbc2e544617d299c. The only changes after locally tested merge revisioncc5c2ff8b65adc5594d1315bcd196e8072aea528are the two generated gallery GIFs: independent review caught an Overview frame mislabeled as Launcher during the first capture, and an isolated recapture corrected it in both themes. Source/runtime/test files are byte-identical to the locally validated merge revision. Final-head CI completed successfully with all six jobs green; earlier reconciliation CI also passed. Independent review approved the final exact head after decoding both committed gallery Launcher slides. No attachment upload or new comment was repeated.