Skip to content

Keep TV Recommendations enabled by default on SHIELD - #215

Merged
bryanroscoe merged 2 commits into
mainfrom
fix/tvrecommendations-default-safety
Oct 23, 2026
Merged

bryanroscoe merged 2 commits into
mainfrom
fix/tvrecommendations-default-safety

Conversation

@bryanroscoe

Copy link
Copy Markdown
Owner

TV Recommendations was marked Safe and selected for default optimization despite an external report of lost SHIELD TV phone-app key input after reboot. It now produces Caution and defaults to Keep, with original consequence text citing the pinned darcy/foster_e Android11 report and explicitly leaving other models/firmware unverified. Restore remains available; manual actions and the safety engine are unchanged.

Evidence and simulated screenshots/short video record shipped-data/default-selection regressions, model limits and validation. The demo catalog and both galleries are regenerated. This v2 correction is separate from PR213, the held experimental catalog and release/device gates.

@bryanroscoe

Copy link
Copy Markdown
Owner Author

i thought this was a key part of bloat removal?

@bryanroscoe

Copy link
Copy Markdown
Owner Author

Yes, TVRecommendations is a debloat target. This draft keeps manual disabling available; it changes the automatic default to Keep and displays Caution.

The reason is an external report associating disablement with phone-remote key input failing after reboot on Shield 2017 (darcy) and 2015 (foster_e) running Android 11. We have not reproduced that behavior, so this is a reported risk rather than confirmed causation, and the warning does not claim other models are affected.

I’m leaving this as a draft pending the product decision on the default. The proposed safeguard does not prevent an informed manual choice.

@bryanroscoe

Copy link
Copy Markdown
Owner Author

Evidence re-posted as attachments. The earlier links used repo-relative paths, which 404 from a PR page. Captured at 97e94c9; write-up: v2/evidence/tvrecommendations-safety/README.md.

caution-review-simulated.webm

caution-detail-simulated.png

optimize-keep-simulated.png

@bryanroscoe
bryanroscoe marked this pull request as ready for review October 23, 2026 03:24
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T03:24:08.034502Z 97e94c9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Keeps both evidence upload paths in v2-tests.yml and regenerates the desktop
and phone galleries from the merged demo data.
@bryanroscoe
bryanroscoe merged commit 6d7ae59 into main Oct 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant