Skip to content

Clean stale and historical comments out of frontend, tests and workflows - #226

Merged
bryanroscoe merged 4 commits into
mainfrom
chore/frontend-comment-cleanup
Oct 23, 2026
Merged

bryanroscoe merged 4 commits into
mainfrom
chore/frontend-comment-cleanup

Conversation

@bryanroscoe

Copy link
Copy Markdown
Owner

Comment-only cleanup across the desktop frontend, mobile app, Kotlin ADB plugin, desktop and mobile tests, e2e, screenshot scripts and GitHub workflows. No Rust (handled separately). A comment-stripping diff of every changed file against main is identical, so no code, strings or markup changed.

Kinds of change:

  • History narration deleted ("used to", "the old …", "2.2.0 called it…", "through v2-2.3.0…", commit hashes, owner/reporter stories, "that is what failed the v2-2.1.0 gallery job").
  • Regression context rewritten as the present-tense constraint it guards (e.g. why loadHealth() can't be awaited before the safety lookup, why $state proxy identity checks drop every load, why the stored shell consent must not be re-read in a loader). #NNN references kept.
  • Regression-test headers now state what the test pins rather than how the bug happened.
  • Orphaned CSS comments whose rules are gone, a few "X-tab-specific styles" dividers, and comments that only restated the code removed.

Comments that were factually wrong:

  • v2/src/routes/snapshots/+page.svelte:123 said the trailing Z is stripped; it is replaced with UTC.
  • v2/src/routes/+page.svelte: the authorization-prompt doc had been merged into isWirelessDebuggingTransport's comment (moved back above authPromptLabel), and the boot-discovery comment sat above forgetBusy and said it scans when "no devices" show up, when it scans when no ready device does (moved above bootDiscovery, corrected).
  • v2/src/routes/devices/[serial]/+page.svelte:
    • meterTone claimed the same thresholds as the memory table's PSS column (75/90 % vs 100/200 MB).
    • Five comments pointed at a "Memory tab" / "Launchers tab"; the tabs are Health and Launcher.
    • reinstallApp carried a comment copied from the enable path about a setup helper that reinstall_existing never touches.
    • resetDeviceState said "← Back to devices" is the only way off the page; loadDevice already navigates to a collapsed alias's own serial.
    • A CSS comment counted "twelve tabs" (there are 13) for a rule that no longer exists.
  • v2/src/lib/components/OptimizeTab.svelte: several comments described a per-row "dropdown" and an italic "Skip (recommended)" option; rows use action pills. Restore's order was given as "Enable / Skip" (it is Keep / Enable), and the callout was said to point at a tab it doesn't name.
  • v2/src/lib/components/AppRow.svelte: "two lines per row" (the cell has three), and "the package id beside" the name (the tags sit beside it; the id has its own line).
  • v2/src/lib/components/RemoteTab.svelte:445: D-pad wedges "in a 3x3 grid"; they are clip-path wedges.
  • v2/src/lib/components/SideloadTab.svelte:547: icon said to read "fetch it"; it is open_in_new.
  • v2/src/lib/components/FilesTab.svelte:516: cited a CLAUDE.md note on component CSS that doesn't exist.
  • v2/src/lib/components/RamBadge.svelte:5: label is turned off in AppRow's RAM column, not only "the Optimize table".
  • v2/src/lib/theme.ts:3: colors live in src/app.css, not +layout.svelte.
  • v2/src/lib/types.ts:408: UpdateInfo.current_notes was described as the after-update notes; no UI reads it (the pop-up uses the bundled CHANGELOG.md).
  • v2/src/lib/contextmenu.ts:128: shouldSuppressDefault said to be exported for the test harness and a dev toggle; neither uses it.
  • v2/src/lib/demo-mock.ts: the plan-filter comment listed three extra packages; the code adds four.
  • v2/mobile/src/lib/types.ts: the SavedDevice doc sat above DeviceFingerprint (moved).
  • v2/mobile/src/lib/session.svelte.ts:317: implied get_entitlement might not exist yet.
  • v2/mobile/src/screens/{Dashboard,Devices}.svelte: called App.svelte's identity note a "banner"; it is a toast.
  • v2/mobile/src/screens/Launcher.svelte:754: "both controls" in a branch that renders only Disable.
  • v2/mobile/tauri-plugin-atv-adb/.../AdbService.kt:69: "both service types"; the scan waits for all three.
  • v2/mobile/tests/parity-rows.test.mjs:220: referred to "an older backend"; mobile ships its own.
  • v2/tests/playback-shell.mjs: said tests/shell-acknowledge.mjs enforces address-vs-identity scoping; it doesn't.
  • v2/tests/icon-alignment.mjs: named .device-row.not-clickable and an align-self: flex-start actions wrapper, neither of which exists now (the top-aligned row is .device-row.unauthorized).
  • v2/tests/app-files-catalog.mjs:39: a search dir outside /sdcard was called a silent no-op; it fails the entry's whole search.
  • v2/screenshots/capture.mjs:1: "Shield Optimizer v2" (product is ATV Optimizer).
  • .github/workflows/v2-release.yml: pointed at a README "release section" (it is "First launch"); described merge-updater as merging per-OS files (it downloads the already-merged asset); said Linux captures fall back to Roboto (the UI fonts are bundled); and kept a note that the phone app isn't on the default branch yet.
  • .github/workflows/v2-tests.yml:1: header listed only Rust and a type check.

Left for the owner: the ubuntu-22.04 pin comments in v2-release.yml / v2-tests.yml give a libwebkit2gtk-4.1-dev naming reason that may not hold on 24.04; unchanged because the real reason couldn't be confirmed.

🤖 Generated with Claude Code

Drop history narration (old behaviour, version stories, removed UI),
state regression guards as constraints, and fix comments that named
tabs, files or behaviour that no longer exist. Comments only.
History narration removed, #154-style references kept, and comments
that documented the wrong declaration or overstated a check corrected.
Comments only.
Remove commit hashes, owner-specific stories and version history from
test headers; keep issue references. Comments only.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T04:11:47.467672Z 5907e34 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bryanroscoe
bryanroscoe merged commit 65b076b into main Oct 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant