Repository navigation
Clean stale and historical comments out of frontend, tests and workflows - #226
Merged
Merged
Conversation
Drop history narration (old behaviour, version stories, removed UI), state regression guards as constraints, and fix comments that named tabs, files or behaviour that no longer exist. Comments only.
History narration removed, #154-style references kept, and comments that documented the wrong declaration or overstated a check corrected. Comments only.
Remove commit hashes, owner-specific stories and version history from test headers; keep issue references. Comments only.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only cleanup across the desktop frontend, mobile app, Kotlin ADB plugin, desktop and mobile tests, e2e, screenshot scripts and GitHub workflows. No Rust (handled separately). A comment-stripping diff of every changed file against
mainis identical, so no code, strings or markup changed.Kinds of change:
loadHealth()can't be awaited before the safety lookup, why$stateproxy identity checks drop every load, why the stored shell consent must not be re-read in a loader).#NNNreferences kept.Comments that were factually wrong:
v2/src/routes/snapshots/+page.svelte:123said the trailingZis stripped; it is replaced withUTC.v2/src/routes/+page.svelte: the authorization-prompt doc had been merged intoisWirelessDebuggingTransport's comment (moved back aboveauthPromptLabel), and the boot-discovery comment sat aboveforgetBusyand said it scans when "no devices" show up, when it scans when no ready device does (moved abovebootDiscovery, corrected).v2/src/routes/devices/[serial]/+page.svelte:meterToneclaimed the same thresholds as the memory table's PSS column (75/90 % vs 100/200 MB).reinstallAppcarried a comment copied from the enable path about a setup helper thatreinstall_existingnever touches.resetDeviceStatesaid "← Back to devices" is the only way off the page;loadDevicealready navigates to a collapsed alias's own serial.v2/src/lib/components/OptimizeTab.svelte: several comments described a per-row "dropdown" and an italic "Skip (recommended)" option; rows use action pills. Restore's order was given as "Enable / Skip" (it is Keep / Enable), and the callout was said to point at a tab it doesn't name.v2/src/lib/components/AppRow.svelte: "two lines per row" (the cell has three), and "the package id beside" the name (the tags sit beside it; the id has its own line).v2/src/lib/components/RemoteTab.svelte:445: D-pad wedges "in a 3x3 grid"; they are clip-path wedges.v2/src/lib/components/SideloadTab.svelte:547: icon said to read "fetch it"; it isopen_in_new.v2/src/lib/components/FilesTab.svelte:516: cited a CLAUDE.md note on component CSS that doesn't exist.v2/src/lib/components/RamBadge.svelte:5:labelis turned off in AppRow's RAM column, not only "the Optimize table".v2/src/lib/theme.ts:3: colors live insrc/app.css, not+layout.svelte.v2/src/lib/types.ts:408:UpdateInfo.current_noteswas described as the after-update notes; no UI reads it (the pop-up uses the bundled CHANGELOG.md).v2/src/lib/contextmenu.ts:128:shouldSuppressDefaultsaid to be exported for the test harness and a dev toggle; neither uses it.v2/src/lib/demo-mock.ts: the plan-filter comment listed three extra packages; the code adds four.v2/mobile/src/lib/types.ts: theSavedDevicedoc sat aboveDeviceFingerprint(moved).v2/mobile/src/lib/session.svelte.ts:317: impliedget_entitlementmight not exist yet.v2/mobile/src/screens/{Dashboard,Devices}.svelte: called App.svelte's identity note a "banner"; it is a toast.v2/mobile/src/screens/Launcher.svelte:754: "both controls" in a branch that renders only Disable.v2/mobile/tauri-plugin-atv-adb/.../AdbService.kt:69: "both service types"; the scan waits for all three.v2/mobile/tests/parity-rows.test.mjs:220: referred to "an older backend"; mobile ships its own.v2/tests/playback-shell.mjs: saidtests/shell-acknowledge.mjsenforces address-vs-identity scoping; it doesn't.v2/tests/icon-alignment.mjs: named.device-row.not-clickableand analign-self: flex-startactions wrapper, neither of which exists now (the top-aligned row is.device-row.unauthorized).v2/tests/app-files-catalog.mjs:39: a search dir outside/sdcardwas called a silent no-op; it fails the entry's whole search.v2/screenshots/capture.mjs:1: "Shield Optimizer v2" (product is ATV Optimizer)..github/workflows/v2-release.yml: pointed at a README "release section" (it is "First launch"); describedmerge-updateras merging per-OS files (it downloads the already-merged asset); said Linux captures fall back to Roboto (the UI fonts are bundled); and kept a note that the phone app isn't on the default branch yet..github/workflows/v2-tests.yml:1: header listed only Rust and a type check.Left for the owner: the
ubuntu-22.04pin comments inv2-release.yml/v2-tests.ymlgive alibwebkit2gtk-4.1-devnaming reason that may not hold on 24.04; unchanged because the real reason couldn't be confirmed.🤖 Generated with Claude Code