Repository navigation
fix: preserve live stdio and exit status on system PATH fallback (4.3.2) - #1080
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the system-
PATHfallback inRunConfiguredFlutterWorkflow(when neither a project.fvmrcnor a global FVM version is configured) withVersionRunner.runby passingechoOutput: true, throwOnError: falsetoProcessService.run.Also prepares release
4.3.2(pubspec.yaml,lib/src/version.dart, andCHANGELOG.md).Problem
When
RunConfiguredFlutterWorkflowexecutes with a project or global SDK selected, it delegates toFlutterService.run->VersionRunner.run, which invokesProcessService.run(..., echoOutput: true, throwOnError: false)(ProcessStartMode.inheritStdio+Ctrl+Ccleanup wait + exit-code passthrough).However, when neither a project nor a global SDK was configured, the fallback to the system
PATHcalledget<ProcessService>().run(cmd, args: args)using the defaultechoOutput: false, throwOnError: true:Process.runbuffered output in memory andFlutterCommand/DartCommand/ExecCommandonly returnedresults.exitCode, so commands likefvm flutter --versionorfvm dart analyzeprinted nothing.fvm flutter runcould not receive interactive terminal input (r/R/q) withoutProcessStartMode.inheritStdio.SIGINT(Ctrl+C) cleanup wait: TheProcess.runpath bypassed theSIGINTcleanup wait introduced in fix: wait for Flutter cleanup after SIGINT #1054.ProcessExceptionon non-zero exit codes: Any non-zero exit status fromflutter test,dart analyze, orfvm execthrew aProcessExceptioninstead of propagating the child's exit code.Changes
lib/src/workflows/run_configured_flutter.workflow.dart: PassechoOutput: true, throwOnError: falsein the system-PATHfallback call toProcessService.run.test/src/workflows/run_configured_flutter.workflow_test.dart: Add unit tests verifying that the system-PATHfallback passesechoOutput: trueandthrowOnError: falseand returns non-zero exit codes without throwingProcessException.pubspec.yaml,lib/src/version.dart,CHANGELOG.md: Bump version to4.3.2.Supersedes #1076.