refactor(superdeck): route image Hero flights through flightShuttleBuilder - #138
Merged
leoafarias merged 7 commits intoSep 28, 2026
Conversation
leoafarias
added this pull request to stack #139
September 25, 2026 19:39
|
Visit the preview URL for this PR (updated for commit 69c880a): https://superdeck-dev--pr138-refactor-image-hero-ifwlt4oe.web.app (expires Sun, 25 Oct 2026 22:01:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bd68fc230762285849207e7e120aaf87cd4ca2f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Route image Hero flights through Flutter's
flightShuttleBuilderpath so image transitions share the same Hero integration as text and code, with cross-fade logic owned byImageHeroFlight.Impacted package
superdeckChanges
ImageHeroFlightwidget whose constructor is directly usable as Flutter's Hero shuttle builder.buildFlightcallback plumbing and the old image flight function.Verification
fvm dart run melos run build_runner:buildfvm dart run melos run analyze:dartfvm flutter test test/src/ui/widgets/hero_element_test.dart test/src/ui/widgets/text_hero_flight_test.dart test/src/markdown/hero_transition_test.dart --reporter expanded(frompackages/superdeck)fvm dart analyze packages/superdeckfvm flutter test packages/superdeck/test/src/ui/widgetsfvm flutter test packages/superdeck/test/src/markdown/hero_transition_test.dart --plain-name 'image Hero interpolates its constraint-derived block size'fvm flutter test packages/superdeck/test/src/markdown/hero_transition_test.dart --plain-name 'image shuttle uses overlay bounds over stale block dimensions'fvm flutter test packages/superdeck/test/src/markdown/hero_transition_test.dart --plain-name 'different image sources blend in both navigation directions'fvm dart run tool/build_layout_showcase.dartandfvm flutter run -t lib/layout_showcase_main.dart -d macos; manually stepped across slides 3↔4 after a hot restart with no runtime exceptions.fvm dart run melos run analyzecompleted Dart analysis but could not run DCM because the local DCM installation is not licensed.