Skip to content

docs(integrations): fix GitHub personal-token instructions to not ask for a password - #46

Merged
krassx merged 2 commits into
bugsee:mainfrom
fishmanalex:fix/github-integration-token-instructions
Sep 5, 2026
Merged

docs(integrations): fix GitHub personal-token instructions to not ask for a password#46
krassx merged 2 commits into
bugsee:mainfrom
fishmanalex:fix/github-integration-token-instructions

Conversation

@fishmanalex

@fishmanalex fishmanalex commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • docs/integrations/providers/github/index.md, "Personal token" section, said: "Provide username and password."
  • GitHub has not accepted account passwords for this kind of integration since 2021, and — confirmed against the actual wizard screenshot (wz_step2_token.png) — the real dialog has a single "Personal token" field, no username field at all, same pattern as GitLab's equivalent step.
  • Every other token-based provider page in this docs set says "paste the generated token" with no username field either.

Changes

  • Updated the instruction to: "Paste the personal access token you just generated." (matches the screenshot and the phrasing convention used elsewhere in this docs set)

Note: an earlier commit on this branch fixed the "password" wording but incorrectly added a username field that doesn't exist in the actual UI. That was caught during a re-verification pass and corrected in the second commit — the diff now reflects the final, screenshot-verified wording.

Test plan

  • npx cspell on the changed file — 0 issues
  • Verified against the actual wz_step2_token.png screenshot that the wizard step has only a token field
  • Cross-checked wording convention against GitLab, Bitbucket, and other token-based provider pages

🤖 Generated with Claude Code

https://claude.ai/code/session_01QnXDhVitCVmMNafPRvKUat

fishmanalex and others added 2 commits September 4, 2026 17:45
… for a password

The "Personal token" auth section said "Provide username and password."
GitHub has not accepted account passwords for this kind of integration
since 2021 — PATs are mandatory. Every other token-based provider page
in this docs set says "paste the generated token"; a user following
this literally would enter their real GitHub password and fail.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Follow-up to the previous commit on this branch. Checked the actual
wizard screenshot (wz_step2_token.png): the real dialog has a single
"Personal token" field and no username field at all, matching
GitLab's equivalent step. The prior fix ("Provide your GitHub
username and the personal access token...") invented a username
field that doesn't exist in the UI. Corrected to match what the
screenshot actually shows and the phrasing convention used by every
other token-based provider page ("paste generated token").

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@krassx

krassx commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Confirmed both ways. I opened wz_step2_token.png — the dialog is titled "GITHUB: PROVIDE TOKEN — STEP 2/4" and has exactly one field, labeled "Personal token", with the hint "You can obtain personal API token here: https://github.com/settings/tokens/new". No username field, no password field.

The server agrees — appserver/code/components/shared/integrator/modules/github/index.js:33-34 consumes a token and nothing else:

} else if (auth.mode === 'token') {
    clientOptions.auth = auth.token.access_token;

The self-correction called out in the description was the right instinct — the intermediate "username + token" wording would have been wrong too. Final wording matches both the screenshot and the convention on the other token-based provider pages. LGTM.

🤖 Generated with Claude Code

@krassx krassx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated against source (see review comment above). Approving.

@krassx
krassx merged commit d9574f5 into bugsee:main Sep 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants